Ship the new WebUI #590
Merged
Ship the new WebUI #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@olizilla any quick thoughts on how to improve the bundling process? |
lidel
force-pushed
the
feat/bundle-webui
branch
from
ae3ed09
to
59ce947
Compare
This is an initial stab at bundling. This PoC is very crude: we just do regular build in `node_modules/` and copy artifacts. Refinements will be introduced in following commits.
WebUI would notice issue eventually, but this gives user an instant fix and results in better UX.
lidel
force-pushed
the
feat/bundle-webui
branch
12 times, most recently
from
5a6e2be
to
b3d12ff
Compare
No longer requires local build. Tries to fetch it from IPFS, then fallbacks to HTTP. Should work on all platforms.
lidel
force-pushed
the
feat/bundle-webui
branch
from
b3d12ff
to
02ee4de
Compare
|
I created some orchestration for fetching prebuilt webui from IPFS:
|
This ensures webui is not stuck with dead API object, which improves UX.
lidel
commented
Oct 4, 2018
| } | ||
| } | ||
| } | ||
|
|
||
| function _isWebuiTab (url) { | ||
| const bundled = !url.startsWith('http') && url.includes('/webui/index.html#/') | ||
| const ipns = url.includes('/webui.ipfs.io/#/') |
There was a problem hiding this comment.
#/ will only be added by the app after the initial bundle has loaded (unless the user has bookmarked it explicitly)...
There was a problem hiding this comment.
Yes, that was on purpose to remove false-positive matches on random websites and avoid double-reload when quickly switching between backends.
lidel
force-pushed
the
feat/bundle-webui
branch
from
8d24e21
to
a6c4a72
Compare
|
Looks stable enough to ship to Beta. Let's smoke-test it there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to replace old Web UI with the bundled one.
It is important to get this right, as we will use similar approach for ipfs-share-files.
Remaining work:
ipfsCompanion.ipfsin background pagenode_modules/..subdir and copy artifacts. Refinements will be introduced in following commitswebui shows IPFS Companion as API ProviderpostinstallstepNice to have, but can be separate PR:
.gitignore) or using a custom ignore files (.wextignore) mozilla/web-ext#940 lands we remove maps manually: size is now under 7MBScreenshot (check location bar)