This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
attempt to handle changes to ipfs swarm peers api #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks @whyrusleeping will take a look later today |
|
Ready for review and merge |
|
Additional tests are in ipfs-inactive/interface-js-ipfs-core#94 |
|
thank you @dignifiedquire So, since we need to provide the same api for js-ipfs and js-ipfs-api and having two return types is weird, the best is just to level up js-ipfs to the latest go-ipfs swarm peers API and make js-ipfs-api always return the same thing, of course that with the caveat that when contacting a go-ipfs 0.4.4 node, some of the properties will be undefined. |
|
@diasdavid updated both PRs. |
|
👍 now just needs an update on js-ipfs ipfs.swarm.peers |
|
@diasdavid js-ipfs PR ipfs/js-ipfs#600 |
daviddias
approved these changes
Nov 17, 2016
@diasdavid can we ship this? |
|
Ship it! :) |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so obviously i don't javascript, but these tests failing my CI is getting old so i've made an effort.
Can someone who knows what they are doing help out here?
cc @diasdavid @dignifiedquire @victorbjelkholm