This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
feat(swarm): update swarm.peers to new api #600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@diasdavid I don't understand this, even though we do a connect before calling |
|
@dignifiedquire got it. you were calling swarm.peers on peerB, it is true that peerA dialed to peerB, but peerB needs time to finish the identify, because until that is finished, it has no idea of has called it. Updating the test :) |
daviddias
force-pushed
the
new-swarm-peers
branch
from
98afc83 to
3fa1438
Compare
|
thanks for updating this @dignifiedquire going to merge into feat/awesome-dag-pb because both depend on an updated interface-ipld-core |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref ipfs-inactive/js-ipfs-http-client#427