chore: test against go-ipfs 0.4.13 #638
Conversation
ghost
assigned 
|
A ton of tests is failing when testing js-ipfs-api against go-ipfs@0.4.13. @keks do you happen the know why? Could this be related to cmds changes? Also, this is why #486 is a P0 //cc @victorbjelkholm |
|
We only merged the cmds stuff right after 0.4.13, so that can't really be the reason. |
|
@keks any other HTTP-API changes that came in 0.4.12 or 0.4.13? |
|
Not sure - 0.4.13 was a hotfix release right after 0.4.12, I think there were very few changes. Do the tests pass for 0.4.12? |
|
@diasdavid installed 0.4.13 and used my net-http-api client against it. All tests passed. |
|
@richardschneider do you make any use of the HTTP Headers in your library? Especially the x-stream and x-chunked? |
|
@diasdavid I don't use any special headers, except asking for GZIP response. |
package.json
Outdated
| @@ -43,7 +43,7 @@ | |||
| "peer-id": "~0.10.3", | |||
| "peer-info": "~0.11.3", | |||
| "promisify-es6": "^1.0.3", | |||
| "pump": "^2.0.0", | |||
| "pump": "^1.0.3", | |||
There was a problem hiding this comment.
@keks @richardschneider this was the culprit! Apologies for taking from your time
Codecov Report
@@ Coverage Diff @@
## master #638 +/- ##
==========================================
- Coverage 84.25% 84.02% -0.24%
==========================================
Files 115 115
Lines 1747 1746 -1
==========================================
- Hits 1472 1467 -5
- Misses 275 279 +4
Continue to review full report at Codecov.
|
No description provided.