Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Redesign #513

Closed
wants to merge 0 commits into from
Closed

[WIP] Redesign #513

wants to merge 0 commits into from

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented Nov 28, 2017

Based on #509

  • Copy To Clipboard button that shows on hover
  • Show user location instead of address
  • Files
  • Settings
  • Peers Search
  • Peers Additional Settings
  • Glowing Icon Top Right
  • Add files to extensions list
  • Integrate Welcome Screen on Menubar instead of different window 😄
  • Improve Welcome Screen with new design
  • Remove useless font styles

@daviddias
Copy link
Member

daviddias commented Nov 28, 2017

Paste screenshots as you go :D

@hacdias
Copy link
Member Author

hacdias commented Nov 28, 2017

image

image

Here (^) are some screenshots of the latest commit on this branch. I'd like to get some feedback about some topics:

  • Should the left panel (peers) be always expanded? If not, should it be like this or something else?
  • There are going to be three different panels on the right side: Your Files, Your Node and Settings. Which one should be the "default"? How to do a smooth navigation between the three? I thought about removing the three dots in the bottom and:
    • When you're on the default, there are two different buttons: one for each of the other panels.
    • When you're not on the default, there is one button: an arrow to go back.
  • Should I put a close button on the top right? (I vote yes) According to Redesign #509 that bit was reserved for actions like "add file" or "add folder". What do you think?

/cc @diasdavid @victorbjelkholm @dimoFeeld

@hacdias
Copy link
Member Author

hacdias commented Nov 28, 2017

image

@daviddias
Copy link
Member

Just gave it a test and I like it!

image

I know there are still work to do (for example, it doesn't show the files yet) so I'll avoid giving feedback there but here are a couple of points on the info menu:

image

image

@hacdias
Copy link
Member Author

hacdias commented Nov 29, 2017

Sorry, I had the protocol and agent versions swapped! Which one should I remove?

@hacdias
Copy link
Member Author

hacdias commented Nov 29, 2017

@diasdavid any feedback about this questions: #513 (comment) ?

@hacdias
Copy link
Member Author

hacdias commented Nov 29, 2017

image

@daviddias
Copy link
Member

Should the left panel (peers) be always expanded? If not, should it be like this or something else?

Let's stick with it expanded now and reevaluate after some usage :)

There are going to be three different panels on the right side: Your Files, Your Node and Settings. Which one should be the "default"?

What about merging the "Your Node" and "Settings" pane into one and then using the left pane to switch between peers and files added?

Should I put a close button on the top right? (I vote yes) According to #509 that bit was reserved for actions like "add file" or "add folder". What do you think?

Not sure. Show me how it looks! :)

Btw, check out ipfs/ipfs-companion#320 (comment)

Can we have a glowing animation of IPFS to demonstrate it's on/off state too??

@hacdias
Copy link
Member Author

hacdias commented Nov 30, 2017

Can we have a glowing animation of IPFS to demonstrate it's on/off state too??

Yes, we can! But where? 😮 I'll try to find a good place to put it, but I'll be waiting for feedback 😄

@daviddias
Copy link
Member

@hacdias perhaps you can reduce its size and keep it as corner element

@hacdias
Copy link
Member Author

hacdias commented Nov 30, 2017

image

image

image

@hacdias hacdias requested a review from daviddias November 30, 2017 23:27
package.json Outdated
@@ -12,7 +12,7 @@
"ipfs-api": "^17.1.3",
"ipfs-geoip": "^2.3.0",
"ipfs-logo": "github:ipfs/logo",
"ipfsd-ctl": "^0.25.1",
"ipfsd-ctl": "^0.26.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did it work flawlessly for you? I'm having a hard time here ipfs-inactive/js-ipfs-http-client#638

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested it yet. Probably later today, but can't now, unfortunately. 😞

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@diasdavid I'm not having issues (to test I deleted every IPFS binary from my computer, removed the ipfs repo and just run station).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can add files still?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I'm not having any issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants