Skip to content
This repository was archived by the owner on Mar 10, 2020. It is now read-only.

Conversation

@victorb
Copy link
Contributor

@victorb victorb commented Sep 25, 2015

Tests were broken due to change in node-ipfsd-ctl. This PR fixes that issue by setting go-ipfs as a direct dependency.

See this issue: ipfs/js-ipfsd-ctl#20

@daviddias
Copy link
Contributor

Thanks @victorbjelkholm ! This seems like to be the solution, but also a quick patch

It seems that @bcomnes is checking a solution that doesn't require the user to install a different version of go-ipfs - ipfs/js-ipfsd-ctl#20 (comment)

Testing that on and will come back here in a sec :)

@daviddias
Copy link
Contributor

This should solve the issue: #65

From IRC:
15:13 <+daviddias> VictorBjelkholm: since ipfsd-ctl PR from bcomnes solves the issue of finding 'go-ipfs', we avoid needing to install it twice
15:13 <+daviddias> take a look at #65, should solve your problem too

Thank you for catching this! :)

@victorb victorb closed this Sep 25, 2015
daviddias added a commit that referenced this pull request Sep 25, 2015
bump ipfsd-ctl version, fixes #64
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants