Require "go-ipfs" directly to get exe path. #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I believe this should normalize behavior between npm2 and 3 once the upstream path export is fixed: ipfs/npm-kubo#2
|
Ok I think this is good to go now. What happens when we re-run the tests? |
This was referenced Sep 25, 2015
|
Nice! tested this and also tested this new ipfsd-ctl on node-ipfs-api and every test passes, should solve the issue for everyone, including ipfs-inactive/js-ipfs-http-client#64 thank you @bcomnes :) |
daviddias
added a commit
that referenced
this pull request
Sep 25, 2015
Require "go-ipfs" directly to get exe path.
65 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this should normalize behavior between npm2 and 3 once the upstream path export is fixed: ipfs/npm-kubo#2
Closes #20