Skip to content

Conversation

@bcomnes
Copy link
Contributor

@bcomnes bcomnes commented Sep 25, 2015

Maybe there is a reason you are not using semver ranges on the dependencies, but this patch fixes that! Feel free to reject if this isn't wanted.

@bcomnes
Copy link
Contributor Author

bcomnes commented Sep 25, 2015

Oops, got ahead of myself here. This will pass once its rebased or merged with #21

package.json Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to be specific? can we not say 0.3.7 and get the (only) one that's published? i checked this manually with npm install 0.3.7 and it installed one... but not with a dep)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure but I'll fix it if it works. I'll I've to check the semver calculator when I get home.

Bret Comnes
http://bret.io
Sent from my mobile

On Sep 25, 2015, at 1:05 PM, Juan Benet notifications@github.com wrote:

In package.json:

@@ -21,19 +21,18 @@
],
"license": "MIT",
"dependencies": {

  • "go-ipfs": "0.3.6",
  • "ipfs-api": "2.2.1",
  • "kew": "0.5.0",
  • "lodash": "3.6.0",
  • "go-ipfs": "0.3.7-3",
    do we need to be specific? can we not say 0.3.7 and get the (only) one that's published? i checked this manually with npm install 0.3.7 and it installed one... but not with a dep)


Reply to this email directly or view it on GitHub.

@jbenet
Copy link
Member

jbenet commented Sep 25, 2015

ok maybe rebase and force push?

@bcomnes
Copy link
Contributor Author

bcomnes commented Sep 25, 2015

I'll rebase this evening after work.

@daviddias
Copy link
Member

LGTM :) thanks @bcomnes !

daviddias added a commit that referenced this pull request Oct 11, 2015
Update package.json to use semver ranges
@daviddias daviddias merged commit 89d010f into ipfs:master Oct 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants