PUBSUB: unsubscribe without handler reference

[Isan-Rivkin]

Hi :-)
following up on an issue in interface-js-ipfs-core I'm creating this PR.
Also created PR in js-libp2p accordingly.
This would help in cases like mine where my implementation is not able to support references to a handler function.
I will add the final url in the README to the method documentation once I merge the final PR to interface-js-ipfs-core since its pointing nowhere now.

Edit:

Opened a PR on interface-js-ipfs-core

[Isan-Rivkin]

What can i do to increase codedov in this case? :-o

[jacobheun]

This PR depends on ipfs-inactive/interface-js-ipfs-core#437. Once that is released it will resolve the code coverage issue here as we'll be running the updated pubsub test suite https://github.com/ipfs/interface-js-ipfs-core/pull/437/files#diff-c75d438d36bbcf7a883a20ff916c89d5

[alanshaw]

@Isan-Rivkin can you update the interface-ipfs-core version so we can double check the tests pass in CI?

Note: we also need a PR to JS IPFS to implement this behaviour.

Thank you 🚀

[alanshaw]

I think the error here is due to the fixtures location changing from "js/test/fixtures" to "test/fixtures" in the interface-ipfs-core project. I think if you do a find/replace for this it'll solve the issue.

[Isan-Rivkin]

@alanshaw That's weird those tests works on my machine lol, will look at this, thanks for the hint!

[Isan-Rivkin]

@alanshaw i tried to debug this but locally everything works, any clue would help 🙏 ?

[alanshaw]

I think that failure is unrelated - I'll be looking into that hopefully this week.

[alanshaw]

@Isan-Rivkin I'm working on getting your work mergable here #956