PUBSUB: unsubscribe without handler reference #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 6, 2019
|
Per ipfs-inactive/interface-js-ipfs-core#437 (comment), I think we should just overload |
|
Also, when you update, can you fix linting |
|
@jacobheun thanks, I commented in interface-js-ipfs. |
Subscribe this point |
Isan-Rivkin
force-pushed
the
master
branch
4 times, most recently
from
c6f56c2 to
4016320
Compare
jacobheun
approved these changes
Feb 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi :-)
following up on an issue in interface-js-ipfs-core I'm creating this PR.
Also created PR in js-ipfs-http-client accordingly.
This would help in cases like mine where my implementation is not able to support references to a handler function.
I will add the final url in the README to the method documentation once I merge the final PR
to interface-js-ipfs-coresince its pointing nowhere now.Edit:
Opened a PR on
interface-js-ipfs-core