Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove need for explicit i18next-icu/locale-data #9

Open
3 of 5 tasks
lidel opened this issue Feb 25, 2021 · 0 comments
Open
3 of 5 tasks

Remove need for explicit i18next-icu/locale-data #9

lidel opened this issue Feb 25, 2021 · 0 comments
Assignees
@lidel
Labels
dif/easy Someone with a little familiarity can pick up kind/maintenance Work required to avoid breaking changes or harm to project's status quo P2 Medium: Good to have, but can wait until someone steps up

Comments

@lidel
Copy link
Member

lidel commented Feb 25, 2021 •
edited
Loading

Latest i18next-icu is capable of delegating locale data to intl-messageformat, removing the need for manual import of every new locale, greatly simplifying our setups.
@lidel lidel added P2 Medium: Good to have, but can wait until someone steps up kind/maintenance Work required to avoid breaking changes or harm to project's status quo dif/easy Someone with a little familiarity can pick up labels Feb 25, 2021
@lidel lidel self-assigned this Feb 25, 2021
lidel added a commit to ipfs-shipyard/ipfs-share-files that referenced this issue Feb 25, 2021
@lidel
chore(i18n): dep bump + automatic locale data
5bef151 
Small i18n refactor that  makes things more future-proof:
ipfs-shipyard/i18n#9
lidel added a commit to ipfs/ipfs-webui that referenced this issue Feb 25, 2021
@lidel
chore(i18n): dep bump + automatic locale data
5984715 
Small i18n refactor that  makes things more future-proof:
ipfs-shipyard/i18n#9
@lidel lidel mentioned this issue Feb 25, 2021
Merged
3 tasks
lidel added a commit to ipfs/ipfs-webui that referenced this issue Mar 4, 2021
@lidel
refactor(i18n): automatic locale data (#1725)
05484ac 
* chore(i18n): dep bump + automatic locale data

Small i18n refactor that  makes things more future-proof:
ipfs-shipyard/i18n#9

* fix(i18n): regression in Trans

Latest i18next-icu uses upstream intl-messageformat for plurals,
unfortunately it means we no longer can mix tags with plurals in Trans
element. This is a cosmetic fix that makes the entire label a link.
rafaelramalho19 pushed a commit to ipfs/ipfs-webui that referenced this issue Mar 12, 2021
@lidel @rafaelramalho19
refactor(i18n): automatic locale data (#1725)
4fa82e1 
* chore(i18n): dep bump + automatic locale data

Small i18n refactor that  makes things more future-proof:
ipfs-shipyard/i18n#9

* fix(i18n): regression in Trans

Latest i18next-icu uses upstream intl-messageformat for plurals,
unfortunately it means we no longer can mix tags with plurals in Trans
element. This is a cosmetic fix that makes the entire label a link.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lidel lidel

Labels
dif/easy Someone with a little familiarity can pick up kind/maintenance Work required to avoid breaking changes or harm to project's status quo P2 Medium: Good to have, but can wait until someone steps up
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lidel