Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(i18n): automatic locale data #1725

Merged
merged 2 commits into from
Mar 4, 2021
Merged

Conversation

lidel
Copy link
Member

@lidel lidel commented Feb 25, 2021

Small i18n refactor that makes things more future-proof.
Details in: ipfs-shipyard/i18n#9

  • integrate lol with build so we no longer miss newly added locales in UI
  • check if ipfs-explorer needs to be updated
  • investigate regression on Status page:

    2021-02-25--22-32-35

Small i18n refactor that  makes things more future-proof:
ipfs-shipyard/i18n#9
Latest i18next-icu uses upstream intl-messageformat for plurals,
unfortunately it means we no longer can mix tags with plurals in Trans
element. This is a cosmetic fix that makes entire label a link.
@lidel lidel marked this pull request as ready for review February 26, 2021 14:14
@lidel lidel requested a review from olizilla February 26, 2021 14:14
@lidel lidel merged commit 05484ac into master Mar 4, 2021
@lidel lidel deleted the refactor/automatic-locale-data branch March 4, 2021 14:36
rafaelramalho19 pushed a commit that referenced this pull request Mar 12, 2021
* chore(i18n): dep bump + automatic locale data

Small i18n refactor that  makes things more future-proof:
ipfs-shipyard/i18n#9

* fix(i18n): regression in Trans

Latest i18next-icu uses upstream intl-messageformat for plurals,
unfortunately it means we no longer can mix tags with plurals in Trans
element. This is a cosmetic fix that makes the entire label a link.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant