Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade API to comply to the IPFS Interface specification (py-ipfs-http-client version) #149

Merged

Conversation

ntninja
Copy link
Contributor

@ntninja ntninja commented Dec 18, 2018

Follow-up from #146. Needs discussion on that PR to complete before it can be merged.

@ghost ghost assigned ntninja Dec 18, 2018
@ghost ghost added the in progress label Dec 18, 2018
Highlights:

  * Splitted the giant `test/funcational/tests.py` into many subtests
  * Migrated all code away from `unittest` to `pytest` native only
  * Enabled the codestyle checker on all of the new test code (and fixed issues)
…es to be shared between all client objects (causing the wrong endpoint to receive the calls!)
@ntninja ntninja changed the title [WIP] Upgrade API to comply to the IPFS Interface specification (py-ipfs-http-client version) Upgrade API to comply to the IPFS Interface specification (py-ipfs-http-client version) Jan 29, 2019
@ntninja
Copy link
Contributor Author

ntninja commented Jan 29, 2019

Finally!

@ntninja ntninja merged commit 695a002 into ipfs-shipyard:py-ipfs-http-client Jan 29, 2019
@ghost ghost removed the in progress label Jan 29, 2019
@ntninja ntninja added this to the ipfs-http-client v0.4.4 milestone Feb 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant