Default values of Client/connect() are not documented

[AuHau]

The #7 was reintroduced I guess by some refactoring. Passing None to Client/connect() will result in no default values used and a not much informative exception:

File "/Users/c5272397/dev/ipfs-publish/.direnv/python-3.6.5/lib/python3.6/site-packages/ipfsapi/http.py", line 143, in __init__
    if not re.match('^https?://', host.lower()):
AttributeError: 'NoneType' object has no attribute 'lower'

I am happy to provide refix, I am only not sure how to proceed because of the on-going renaming (#148). Should I wait until merged, target some specific branch or something else? Please let me know.

[ntninja]

Thanks for your feedback! I've finally received some feedback on the discussion regarding the files-APIs in #146, so there will finally be progress now on the py-ipfs-api/py-ipfs-http-client rename+redesign thing. As such I'd ask you to wait another week or so before proposing any patches.

Two comments on your post however:

1. I'm really convinced we're talking about a bug here, since the default values for the host and port are ipfsapi.DEFAULT_HOST & ipfsapi.DEFAULT_PORT respectively. I do see however that the documentation doesn't show this fact unfortunately – which I definitely consider a bug on the other hand.
2. Part of the aforementioned redesign will be the fact the client will use a multiaddr instead of the host+port+base triplet currently in use, hence why I'm asking you to delay any patches for now.

[AuHau]

Okey! I will wait and follow the #149 and after completion then revisit.

Thanks for the reply!

[ntninja]

As mentioned in #150 this won't be “fixed” by allowing None; rather we'll update the documentation to highlight that ipfshttpclient.DEFAULT_{HOST,PORT,BASE} are the respective default values.