Final changes for py-ipfs-http-client
#181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When adding a directory from a file descriptor (the default for Python3 on Linux) the top-level added directory would end up being `<dirname>/` rather then just `<dirname>` which would cause the directory to be sent twice to the daemon which would then normalize the paths to the same name but treat them as separate entities hence returning an extra empty directory result for the first name.
…stricting the address family used during name resolution
…he `Client` class instance
Most parts of the codebase were already using tabs before this and only needed small adjustments.
ntninja
force-pushed
the
py-ipfs-http-client
branch
from
f2da6da to
cb6d1b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's been a long time in the making, but I think it may now be done.
closes #180
closes #150