Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve many things about the documentation #168

Merged

Conversation

ntninja
Copy link
Contributor

@ntninja ntninja commented Feb 16, 2019

@ghost ghost assigned ntninja Feb 16, 2019
@ghost ghost added the in progress label Feb 16, 2019
ntninja and others added 2 commits March 5, 2019 22:23
  * Better signature for the `connect` function (fixes ipfs-shipyard#150)
  * Document the `stream` parameter
  * Return values are now *documented*, not *commented* on (syntactial change)
  * Document the JSON object keys of several methods separately
Python encodes ASCII by default and escapes the unicode characters.
This fix enforces utf-8.
@ntninja ntninja force-pushed the py-ipfs-http-client branch from f81537a to 71ebd58 Compare March 5, 2019 21:23
@ntninja ntninja force-pushed the py-ipfs-http-client branch from 71ebd58 to 5297e66 Compare March 5, 2019 21:46
@ntninja
Copy link
Contributor Author

ntninja commented Mar 5, 2019

@ntninja ntninja merged commit 1f20e52 into ipfs-shipyard:py-ipfs-http-client Mar 5, 2019
@ghost ghost removed the in progress label Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants