Skip to content

Document, test, and improve functionality. #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Aug 2, 2016

Conversation

whereswaldon
Copy link
Contributor

@whereswaldon whereswaldon commented Jul 22, 2016

We've written unit and functional tests for most of the project. Additionally, we've implemented some chunks of the core spec that were missing. We have all of the Core API spec implemented with the exception of node_start, node_stop, repo_init, repo_config_get, and repo_config_set. We also have a working version of add, cat, and get. (Add does not currently handle filtering added files by a regular expression though.)

Resolves #45 and #34 .

jlstack and others added 13 commits July 22, 2016 15:38
License: MIT
Signed-off-by: Luke Stack <stackjl@appstate.edu>
License: MIT
Signed-off-by: Zlati Gardev zgardev@yahoo.com
…t_http.py.

License: MIT
Signed-off-by: Ryan Soley <resoley@us.ibm.com>
Most of the docs were based on or copied from the IPFS Apiary and/or the CLI itself.
Much will need to be updated as the project progresses.

License: MIT
Signed-off-by: Luke Stack <stackjl@appstate.edu>
I also removed the pep8 checks for __init__.py files
since necessary 'unused imports' often appear.

License: MIT
Signed-off-by: Luke Stack <stackjl@appstate.edu>
License: MIT
Signed-off-by: Christopher Waldon <christopher.waldon.dev@gmail.com>
License: MIT
Signed-off-by: Christopher Waldon <christopher.waldon.dev@gmail.com>
Add functionality fixed and correctly tested.
Object path subcommands scaffolded.
Object new command implemented and tested.
Block get, block stat, and block put tested.

License: MIT
Signed-off-by: Christopher Waldon <christopher.waldon.dev@gmail.com>
License: MIT
Signed-off-by: Ryan Soley <resoley@us.ibm.com>
License: MIT
Signed-off-by: Ryan Soley <resoley@us.ibm.com>
License: MIT
Signed-off-by: Christopher Waldon <christopher.waldon.dev@gmail.com>
License: MIT
Signed-off-by: Christopher Waldon <christopher.waldon.dev@gmail.com>
License: MIT
Signed-off-by: Christopher Waldon <christopher.waldon.dev@gmail.com>
@whereswaldon
Copy link
Contributor Author

Actually, we're not quite ready yet. Just realized this branch is missing something. Will open a new one when fixed.

ZmG and others added 2 commits July 23, 2016 12:30
Added pin tests
Added log functions/tests
Added other random tests
Removed tailing separator on directory paths in multipart

License: MIT
Signed-off-by: Luke Stack <stackjl@appstate.edu>
@whereswaldon
Copy link
Contributor Author

whereswaldon commented Jul 23, 2016

Okay, fixed now.
After this PR, project status (as per #42) is:

  • version - DONE
  • node - Some subcommands implemented
    • id - DONE
    • start - Unimplemented
    • stop - Unimplemented
  • block - DONE
    • get - DONE
    • put - DONE
    • stat -DONE
  • object - DONE
    • data - DONE
    • get - DONE
    • links - DONE
    • new - DONE
    • patch - DONE
    • put - DONE
    • stat - DONE
  • refs - DONE
    • local -DONE
  • repo - Some subcommands implemented
    • init - Unimplemented
    • stat - DONE
    • gc - DONE
    • config get - Unimplemented
    • config put - Unimplemented
  • pin - DONE
    • add - DONE
    • ls - DONE
    • rm - DONE

Additionally, we've fixed and tested the Files extension and the Log extension:

  • files - DONE
    • add - DONE (except for addition only files that match a RegEx)
    • cat - DONE
    • get - DONE
  • log - DONE
    • level - DONE
    • tail - DONE

@ghost
Copy link

ghost commented Jul 27, 2016

This is great, thanks so much! :) I have only very little experience with python so I can't give much valuable feedback. @Alexander255 @amstocker @jbenet what do you think?

@parkan
Copy link

parkan commented Aug 1, 2016

👍 on this, we're currently shelling out to go-ipfs to do recursive adds

@amstocker amstocker merged commit 660451a into ipfs-shipyard:master Aug 2, 2016
This was referenced Aug 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants