Fix TravisCI and make compatible with go-ipfs v0.4.3rc2 #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 10, 2016 07:29
go-ipfs v0.4.3rc2 has changed to the IPFS api some. This commit updates the responses that our tests expect to match those from this newer API, as well as fixing the handling for adding strings (which appears to have changed a lot). It also updates the README to specify which version of IPFS is being tested against so that users can make more informed decisions when using this package. License: MIT Signed-off-by: Christopher Waldon <ckwaldon@us.ibm.com>
TravisCI now installs the latest version of IPFS and runs the daemon before starting the testing suite. This means that the functional tests can now pass, whereas before they "failed to connect" to a non-running daemon. Unfortunately, TravisCI will "go get" IPFS, which gives us no control over the version. We will get whatever the latest commit is. As soon as go-ipfs v0.4.3 is finalized and released, the TravisCI config should be changed to install that instead. License: MIT Signed-off-by: Christopher Waldon <ckwaldon@us.ibm.com>
Also run only current Python version tests in TravisCI matrix. License: MIT Signed-off-by: Christopher Waldon <ckwaldon@us.ibm.com>
| before_script: | ||
| - wget "https://dist.ipfs.io/go-ipfs/v0.4.3-rc2/go-ipfs_v0.4.3-rc2_linux-amd64.tar.gz" -O /tmp/ipfs.tar.gz | ||
| - mkdir $HOME/bin | ||
| - pushd . && cd $HOME/bin && tar -xzvf /tmp/ipfs.tar.gz && popd |
There was a problem hiding this comment.
I have never used Travis before: Are its scripts guaranteed to be run with bash?
There was a problem hiding this comment.
I don't know, actually. I took the way that I did this from the TravisCI Documentation. Do you have a different way of doing this in mind?
There was a problem hiding this comment.
If it's in the official docs then it's fine. I just have seen too many thing fail because of bashisms to not ask. 😉
|
Tested and verified that it indeed fixes all functional tests in |
|
Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TravisCI previously ignored the functional tests that required an IPFS daemon to be running. #46 enabled those tests, but did not configure TravisCI to run an IPFS daemon. Now, Travis will download the release version of go-ipfs v0.4.3rc2 and run it before running the tests, ensuring that the functional tests pass too.
There have been some changes to the HTTP API responses since go-ipfs v0.4.3rc1, so this PR also updates the tests to reflect those changes.
This will resolve #50