-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Do Not Merge] ipsl: compiler and mesh for ipsl structure #33
Conversation
License: MIT Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch> This commit was moved from ipfs/go-unixfs@8bf6483
License: MIT Signed-off-by: Jeromy <jeromyj@gmail.com> This commit was moved from ipfs/go-unixfs@5e8347c
fix: multiple govet warnings This commit was moved from ipfs/go-unixfs@12d16cb
License: MIT Signed-off-by: Jeromy <jeromyj@gmail.com> This commit was moved from ipfs/go-unixfs@1f3adf3
License: MIT Signed-off-by: Kevin Atkinson <k@kevina.org> This commit was moved from ipfs/go-unixfs@123b0fd
…n nil License: MIT Signed-off-by: Kevin Atkinson <k@kevina.org> This commit was moved from ipfs/go-unixfs@c1e9ccd
License: MIT Signed-off-by: Kevin Atkinson <k@kevina.org> This commit was moved from ipfs/go-unixfs@957da2c
License: MIT Signed-off-by: Kevin Atkinson <k@kevina.org> This commit was moved from ipfs/go-unixfs@e19161f
License: MIT Signed-off-by: Jeromy <jeromyj@gmail.com> This commit was moved from ipfs/go-unixfs@fb78dc2
License: MIT Signed-off-by: Jeromy <jeromyj@gmail.com> This commit was moved from ipfs/go-unixfs@a01e57d
License: MIT Signed-off-by: Jeromy <jeromyj@gmail.com> This commit was moved from ipfs/go-unixfs@4f4ba29
License: MIT Signed-off-by: Zach Ramsay <zach.ramsay@gmail.com> This commit was moved from ipfs/go-unixfs@ee18aaa
License: MIT Signed-off-by: Zach Ramsay <zach.ramsay@gmail.com> This commit was moved from ipfs/go-unixfs@427d991
License: MIT Signed-off-by: Zach Ramsay <zach.ramsay@gmail.com> This commit was moved from ipfs/go-unixfs@6b9f909
License: MIT Signed-off-by: Jeromy <jeromyj@gmail.com> This commit was moved from ipfs/go-unixfs@982e553
License: MIT Signed-off-by: Kevin Atkinson <k@kevina.org> This commit was moved from ipfs/go-unixfs@ec9e96f
License: MIT Signed-off-by: Kevin Atkinson <k@kevina.org> This commit was moved from ipfs/go-unixfs@db7c21c
And updated related dependencies. License: MIT Signed-off-by: Steven Allen <steven@stebalien.com> This commit was moved from ipfs/go-unixfs@ee13c79
License: MIT Signed-off-by: Łukasz Magiera <magik6k@gmail.com> This commit was moved from ipfs/go-unixfs@4597735
License: MIT Signed-off-by: Jeromy <jeromyj@gmail.com> This commit was moved from ipfs/go-unixfs@3da5638
License: MIT Signed-off-by: Steven Allen <steven@stebalien.com> This commit was moved from ipfs/go-unixfs@ef6144d
License: MIT Signed-off-by: Łukasz Magiera <magik6k@gmail.com> This commit was moved from ipfs/go-unixfs@6d45943
License: MIT Signed-off-by: Łukasz Magiera <magik6k@gmail.com> This commit was moved from ipfs/go-unixfs@f98d19a
License: MIT Signed-off-by: Kevin Atkinson <k@kevina.org> This commit was moved from ipfs/go-unixfs@5a0548a
License: MIT Signed-off-by: Kevin Atkinson <k@kevina.org> This commit was moved from ipfs/go-unixfs@e3ad5de
License: MIT Signed-off-by: Kevin Atkinson <k@kevina.org> This commit was moved from ipfs/go-unixfs@109d198
License: MIT Signed-off-by: Kevin Atkinson <k@kevina.org> This commit was moved from ipfs/go-unixfs@9501516
License: MIT Signed-off-by: Kevin Atkinson <k@kevina.org> This commit was moved from ipfs/go-unixfs@d0d21fa
License: MIT Signed-off-by: Kevin Atkinson <k@kevina.org> This commit was moved from ipfs/go-unixfs@e94381a
gateway: fix seeker can't seek on specific files This commit was moved from ipfs/go-unixfs@a1739b5
Codecov Report
@@ Coverage Diff @@
## main ipfs/go-libipfs#33 +/- ##
===========================================
+ Coverage 17.95% 31.91% +13.95%
===========================================
Files 94 101 +7
Lines 10368 11841 +1473
===========================================
+ Hits 1862 3779 +1917
+ Misses 8245 7544 -701
- Partials 261 518 +257
|
This is needed because the unixfs tests imports go-block-format.
Will be fine performance wise once #57 is fixed.
Is there a definition of what the IPSL is? |
@willscott I have an incomplete incorrect spec draft here: https://hackmd.io/@UV0H7uWJTQ6Wm8jsq8w8mQ/BydHhrN5s TL;DR: This is a low development cost extensible alternatives to selectors. So for example you could run selectors on top of IPSL, by implementing them in wasm for example. And use selectors on a remote node that does not implement them. |
I would encourage getting review/alignment with current/former IPLD members that have thought about selector expressiveness and goals - e.g. @rvagg , @RangerMauve, @warpfork |
@willscott you are starting the politics earlier than I meant too, I don't have a proper RFC ready 😅
we already had the cid bytes pair in kubo since the beggining, it's so old it predates CIDs:
In case this was unclear, the About the rest of things here there is one alpha partial implementation (this PR). traversal := ipsl.NewDepthLimit(10, ipsl.NewAll(
unixfs.Name(match.Wildcard("file1*"), unixfs.Everything())),
unixfs.Name(match.Eq("file2"), unixfs.Range(0xFF1024, 0x2FF0555, unixfs.Everything()))) This correspond to this request:
I've tried using selectors for this, but the API is unreadable and they are hard to use (current implementation is not comparable and hard to make so due to reification and hidden internal state). This is needed because this allows RAPIDE (new download client) to have a "full view" of the request, instead of sequential calls to Goals
DesignThe way features are meant to be implemented is in three ways:
|
Thanks for the detailed response! I think the core of my push previously is that I don't fully understand what it means for something to be merged into libipfs, and if that means it's considered blessed as a core spec. If we're asking for review to merge this as an approved part of what ipfs is, that seems like it's ready for review? It seems like you're saying this is at an experimental level, but i'm not sure how we distinguish between experimental and important/maintained parts of what's living in this repo |
@willscott I see what you mean now, there is no plans to merge this in libipfs yet, I've switched it from draft because it now has a minimal PoC people can play with and I wished to start gathering reviews from the rest of the team. We have not yet decided if we will follow through with that project yet. 🙂 |
This remove the fake scopes nodes we had in the middle of the tree. Now Serialize return BoundScope objects which are used by Uncompile to rebuild the Ast.
Superseeded by #148 |
This still requires lots of work.
This include a mostly complete compiler, (minus a few types and literals). More nodes and scopes will be required.
TODO (for later PRs):
AstNode
collect scopes (stop wrapping, probably makeSerialize() (AstNode, Scopes, error)
) or similar.Depends on (include) #36
Fixes ipfs#3