-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add changelog update checker workflow #398
Conversation
Codecov Report
@@ Coverage Diff @@
## main #398 +/- ##
==========================================
+ Coverage 49.49% 49.53% +0.04%
==========================================
Files 248 248
Lines 29838 29838
==========================================
+ Hits 14769 14781 +12
+ Misses 13640 13632 -8
+ Partials 1429 1425 -4 |
@galargh question: will we need to add |
Good call! How about we trigger only on PRs that modify Go files (including go.mod/go.sum)? I think that should cover the cases where CHANGELOG update might be required. |
Okay, I think it sounds good. I'm happy to get this merged. We can always make any improvements if we find something. |
Resolves #267
This PR adds a CI workflow which checks whether the PR contains CHANGELOG.md modifications.
The check can be skipped by either adding
[skip changelog]
to the PR title or labelling the PR withskip/changelog
. These instructions are included in the PR template and in the workflow failure message.The checks succeeds if CHANGELOG.md was modified and fails otherwise.
Tested in galargh/.github#40