-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v0.10.2 #401
Release v0.10.2 #401
Conversation
hacdias
commented
Jun 29, 2023
•
edited
Loading
edited
- Gateway sharness will fail as Kubo master has changes that are incompatible.
Codecov Report
@@ Coverage Diff @@
## release #401 +/- ##
===========================================
+ Coverage 50.64% 50.91% +0.26%
===========================================
Files 281 281
Lines 34043 34057 +14
===========================================
+ Hits 17242 17340 +98
+ Misses 15016 14925 -91
- Partials 1785 1792 +7
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested version: Changes in (empty)
Cutting a Release (when not on
|
|
I've been able to identify that the issue with |
I managed to reproduce the error in much smaller setup! Looks like it happens when we import go-libp2p 😕 Here's the repo setup where I reproduced it: https://github.com/galargh/gorelease-go1.20.5 And a GHA run that shows it suceeds on 1.20.4 and fails on 1.20.5: https://github.com/galargh/gorelease-go1.20.5/actions/runs/5422828051 |
And it should be fixed in Go 1.20.6 - related issue golang/go#60698 |