Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.10.2 #401

Merged
merged 4 commits into from
Jun 29, 2023
Merged

Release v0.10.2 #401

merged 4 commits into from
Jun 29, 2023

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented Jun 29, 2023

  • Gateway sharness will fail as Kubo master has changes that are incompatible.

@hacdias hacdias requested review from lidel and Jorropo June 29, 2023 14:22
@hacdias hacdias added the release Merging this PR will create a tagged release label Jun 29, 2023
@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Merging #401 (2d3edc5) into release (198f9bc) will increase coverage by 0.26%.
The diff coverage is 84.24%.

Impacted file tree graph

@@             Coverage Diff             @@
##           release     #401      +/-   ##
===========================================
+ Coverage    50.64%   50.91%   +0.26%     
===========================================
  Files          281      281              
  Lines        34043    34057      +14     
===========================================
+ Hits         17242    17340      +98     
+ Misses       15016    14925      -91     
- Partials      1785     1792       +7     
Impacted Files Coverage Δ
gateway/handler_ipns_record.go 18.46% <50.00%> (ø)
gateway/hostname.go 73.79% <77.77%> (+6.13%) ⬆️
gateway/handler_car.go 70.22% <81.81%> (+5.34%) ⬆️
gateway/handler_defaults.go 40.26% <82.35%> (ø)
gateway/handler_codec.go 62.18% <85.00%> (+7.23%) ⬆️
gateway/handler_block.go 83.78% <85.71%> (ø)
gateway/handler.go 77.70% <87.09%> (+6.34%) ⬆️
gateway/handler_tar.go 79.36% <87.50%> (ø)
gateway/gateway.go 92.55% <100.00%> (+0.33%) ⬆️

... and 15 files with indirect coverage changes

Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#337 and #395 alone lgtm – as long you have a PR for Kubo 0.21 release branch that has sharness green.

@github-actions
Copy link

Suggested version: v0.10.2

Comparing to: v0.10.1 (diff)

Changes in go.mod file(s):

(empty)

gorelease says:

gorelease: go: updates to go.sum needed, disabled by -mod=readonly

gocompat says:

Your branch is up to date with 'origin/release'.

Cutting a Release (when not on main)

This PR is targeting release, which is not the default branch.
If you wish to cut a release once this PR is merged, please add the release label to this PR.

Cutting a Release (and modifying non-markdown files)

This PR is modifying both version.json and non-markdown files.
The Release Checker is not able to analyse files that are not checked in to release. This might cause the above analysis to be inaccurate.
Please consider performing all the code changes in a separate PR before cutting the release.

Automatically created GitHub Release

A draft GitHub Release has been created.
It is going to be published when this PR is merged.
You can modify its' body to include any release notes you wish to include with the release.

@Jorropo
Copy link
Contributor

Jorropo commented Jun 29, 2023

 gorelease: go: updates to go.sum needed, disabled by -mod=readonly
$ findf -name "go.mod" | while read p; do cd $(dirname $p); go mod tidy; cd -; done
/home/hugo/Documents/Scripts/boxo
/home/hugo/Documents/Scripts/boxo
git/home/hugo/Documents/Scripts/boxo
 status
/home/hugo/Documents/Scripts/boxo
$ git status
Sur la branche release-v0.10.2
Votre branche est à jour avec 'origin/release-v0.10.2'.

rien à valider, la copie de travail est propre

gorelease complains about go.sum even tho it is good for me, sounds like a bug cc @galargh
(My random guess is that you go run .../gorelease or go install ../gorealease inside this repo which adds the gorelease entry to the go.mod file and make the go.sum out of sync.)

@hacdias hacdias marked this pull request as ready for review June 29, 2023 14:38
@hacdias hacdias requested a review from a team as a code owner June 29, 2023 14:38
@hacdias hacdias merged commit 61f2939 into release Jun 29, 2023
@galargh
Copy link
Contributor

galargh commented Jun 30, 2023

gorelease complains about go.sum even tho it is good for me, sounds like a bug cc @galargh

I've been able to identify that the issue with goreleaser started occurring when we moved from Go 1.20.4 to Go 1.20.5. I'm not yet sure why.

@galargh
Copy link
Contributor

galargh commented Jun 30, 2023

I managed to reproduce the error in much smaller setup! Looks like it happens when we import go-libp2p 😕 Here's the repo setup where I reproduced it: https://github.com/galargh/gorelease-go1.20.5 And a GHA run that shows it suceeds on 1.20.4 and fails on 1.20.5: https://github.com/galargh/gorelease-go1.20.5/actions/runs/5422828051

@galargh
Copy link
Contributor

galargh commented Jun 30, 2023

And it should be fixed in Go 1.20.6 - related issue golang/go#60698

@hacdias hacdias deleted the release-v0.10.2 branch February 20, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Merging this PR will create a tagged release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants