feat: export routing/http/client.Client #478
Conversation
Codecov Report
@@ Coverage Diff @@
## main #478 +/- ##
==========================================
+ Coverage 65.69% 65.78% +0.09%
==========================================
Files 208 208
Lines 25099 25099
==========================================
+ Hits 16488 16512 +24
+ Misses 7152 7136 -16
+ Partials 1459 1451 -8
|
| @@ -28,7 +28,7 @@ import ( | |||
| ) | |||
|
|
|||
| var ( | |||
| _ contentrouter.Client = &client{} | |||
| _ contentrouter.Client = &Client{} | |||
There was a problem hiding this comment.
@hacdias Given https://specs.ipfs.tech/routing/http-routing-v1/ maybe call this DelegatedRoutingClient ?
I imagine someone integrating IPFS or experimenting in a single .go file with some PoC may have multiple "clients" (DNS, Kubo RPC, Pinning service, and now this), better to have meaningful names to reduce cognitive load?
There was a problem hiding this comment.
@lidel hmm, that feels a bit long. I think the main issue here is also the package name. It';s just called client. If it were called something else, it would be much more explicit, like delegatedrouting.Client.
|
Let's just include this in #479. |
Exports Routing V1 client so people can pass it around in their implementations. At the moment it can't be added to structs, or, for example, passed to a function, since it is unexported.