Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade deps #20

Closed
wants to merge 1 commit into from
Closed

Upgrade deps #20

wants to merge 1 commit into from

Conversation

n0izn0iz
Copy link
Collaborator

@n0izn0iz n0izn0iz commented Nov 10, 2021

Hey,

I tried to be proactive about the go-datastore changes, I slapped the context in so maybe some changes are required

I opened this so the "work" doesn't stay on my computer but it's also to show Berty's interest in this package

There is some work that we'd like to upstream there: https://github.com/berty/go-ipfs-repo-encrypted/blob/master/sqlcipher.go
(support for sqlite and sqlcipher drivers), let me know if it's okay to open a PR for this (maybe an issue first ? ^^)
[EDIT] opened here #21

@guseggert
Copy link

This is great, thanks! I'll get a new version released for this.

@guseggert
Copy link

guseggert commented Nov 10, 2021

I ran the tests manually since it doesn't look like the CI tests are running for some reason:

ctr_id=$(docker run -d -it --rm -e POSTGRES_HOST_AUTH_METHOD=trust -v $PWD:/m postgres)
docker exec -it $ctr_id bash

# then in the container
apt-get update && \
    apt-get -y upgrade && \
    apt-get -y install git curl build-essential && \
    cd && \
    git clone https://github.com/asdf-vm/asdf.git ~/.asdf --branch v0.8.1 && \
    . ~/.asdf/asdf.sh && \
    asdf plugin add golang && \
    asdf install golang latest && \
    asdf global golang latest && \
    cd /m && \
    go test -v ./...

They pass

@n0izn0iz
Copy link
Collaborator Author

just realised I missed the gx part, no sure how to upgrade it though

@marten-seemann
Copy link
Member

just realised I missed the gx part, no sure how to upgrade it though

We're not using gx any more. I removed the file in #22.

@guseggert
Copy link

@n0izn0iz is this ready for review?

@n0izn0iz
Copy link
Collaborator Author

@BigLep
Copy link

BigLep commented Jan 7, 2022

2022-01-07 conversation: @guseggert is in progress on getting this merged.

@n0izn0iz n0izn0iz closed this Jan 7, 2022
@n0izn0iz n0izn0iz deleted the dsctx branch January 7, 2022 17:19
@BigLep
Copy link

BigLep commented Jan 7, 2022

@n0izn0iz @guseggert : just checking - is this supposed to be closed given the PR wasn't merged?

@guseggert
Copy link

The only thing missing is upgrading to github.com/lib/pq@v1.10.4, do you need that @n0izn0iz ?

@n0izn0iz
Copy link
Collaborator Author

n0izn0iz commented Jan 8, 2022

nope we don't use postgres, I saw the better changes merged to master so I happily closed :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants