-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade deps #20
Upgrade deps #20
Conversation
This is great, thanks! I'll get a new version released for this. |
I ran the tests manually since it doesn't look like the CI tests are running for some reason:
They pass |
just realised I missed the gx part, no sure how to upgrade it though |
We're not using gx any more. I removed the file in #22. |
@n0izn0iz is this ready for review? |
2022-01-07 conversation: @guseggert is in progress on getting this merged. |
@n0izn0iz @guseggert : just checking - is this supposed to be closed given the PR wasn't merged? |
The only thing missing is upgrading to |
nope we don't use postgres, I saw the better changes merged to master so I happily closed :) |
Hey,
I tried to be proactive about the go-datastore changes, I slapped the context in so maybe some changes are required
I opened this so the "work" doesn't stay on my computer but it's also to show Berty's interest in this package
There is some work that we'd like to upstream there: https://github.com/berty/go-ipfs-repo-encrypted/blob/master/sqlcipher.go
(support for sqlite and sqlcipher drivers), let me know if it's okay to open a PR for this (maybe an issue first ? ^^)
[EDIT] opened here #21