-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: sqlite support #21
Conversation
13f2b5d
to
dcf37cb
Compare
df3c3bb
to
5a9304f
Compare
Let's land #20 first and try and get CI passing here. There's some ongoing work updating the go-datastore interface and bubbling the dependency up, we can tackle this once that's done. |
I think we've gotten the github actions / testing backlog to a decent place. Do you have time to rebase this, @n0izn0iz , or would you like me to try to take a stab at it? |
The branch is outdated too (some queries are wrong) If you feel like doing it proper, it would be awesome Just please keep in mind we need to use the sqlcipher driver which conflicts on import with the mattn sql driver (same driver name) This package (go-ds-sql) is used for almost all berty storage needs on mobile (it backs a full ipfs repo, berty internals, go-orbit-db, a config kv store, javascript async-storage (hence redux persistance)) If there is a better solution to back datastores for extremely low memory (we need to read the datastores in iOS "app extension" which has around 30MB limit IIRC) and encryption, I would be glad to hear about it :) |
Like some of the other go-do-* repositories (e.g., ipfs/go-ds-s3 ), these aren't core to the development of go-ipfs for example and thus don't necessarily have dedicated maintainers supporting them, especially when they're already strapped. I'd like to find a way to denote that this repo is in need of maintainers. Until we have anyone committed to it, PRs here will likely stall. |
@BigLep should we fork it (@berty) and become maintainers or do you want to give rights on this repo? |
I don't know if I'll get to it any time particularly soon 😓 I'd be happy for you to have rights on the repo, @n0izn0iz |
@willscott no problem, it's fine for me |
@n0izn0iz I gave you write access to the repo. lmk if you need anything else |
46f99ef
to
b893409
Compare
Adds support for sqlite