Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sqlite support #21

Merged
merged 1 commit into from
Jan 28, 2022
Merged

feat: sqlite support #21

merged 1 commit into from
Jan 28, 2022

Conversation

n0izn0iz
Copy link
Collaborator

@n0izn0iz n0izn0iz commented Nov 12, 2021

Adds support for sqlite

@n0izn0iz n0izn0iz changed the title Sqlite feat: sqlite support Nov 12, 2021
@n0izn0iz n0izn0iz force-pushed the sqlite branch 3 times, most recently from 13f2b5d to dcf37cb Compare November 12, 2021 21:33
@n0izn0iz n0izn0iz force-pushed the sqlite branch 2 times, most recently from df3c3bb to 5a9304f Compare November 12, 2021 23:14
@n0izn0iz n0izn0iz mentioned this pull request Nov 15, 2021
@aschmahmann
Copy link

Let's land #20 first and try and get CI passing here. There's some ongoing work updating the go-datastore interface and bubbling the dependency up, we can tackle this once that's done.

@n0izn0iz n0izn0iz changed the title feat: sqlite support WIP - feat: sqlite support Dec 15, 2021
@willscott
Copy link
Contributor

I think we've gotten the github actions / testing backlog to a decent place. Do you have time to rebase this, @n0izn0iz , or would you like me to try to take a stab at it?

@n0izn0iz
Copy link
Collaborator Author

n0izn0iz commented Jan 8, 2022

The branch is outdated too (some queries are wrong)
(See https://github.com/berty/go-ipfs-repo-encrypted/blob/master/sqlcipher.go)

If you feel like doing it proper, it would be awesome

Just please keep in mind we need to use the sqlcipher driver which conflicts on import with the mattn sql driver (same driver name)

This package (go-ds-sql) is used for almost all berty storage needs on mobile (it backs a full ipfs repo, berty internals, go-orbit-db, a config kv store, javascript async-storage (hence redux persistance))

If there is a better solution to back datastores for extremely low memory (we need to read the datastores in iOS "app extension" which has around 30MB limit IIRC) and encryption, I would be glad to hear about it :)

@aschmahmann aschmahmann added the need/author-input Needs input from the original author label Jan 14, 2022
@BigLep
Copy link

BigLep commented Jan 14, 2022

Like some of the other go-do-* repositories (e.g., ipfs/go-ds-s3 ), these aren't core to the development of go-ipfs for example and thus don't necessarily have dedicated maintainers supporting them, especially when they're already strapped.

I'd like to find a way to denote that this repo is in need of maintainers. Until we have anyone committed to it, PRs here will likely stall.

@n0izn0iz
Copy link
Collaborator Author

@BigLep should we fork it (@berty) and become maintainers or do you want to give rights on this repo?
@willscott didn't you want to try it ?

@willscott
Copy link
Contributor

I don't know if I'll get to it any time particularly soon 😓

I'd be happy for you to have rights on the repo, @n0izn0iz

@n0izn0iz
Copy link
Collaborator Author

@willscott no problem, it's fine for me

@aschmahmann
Copy link

@n0izn0iz I gave you write access to the repo. lmk if you need anything else

@n0izn0iz n0izn0iz force-pushed the sqlite branch 7 times, most recently from 46f99ef to b893409 Compare January 28, 2022 09:28
@n0izn0iz n0izn0iz added kind/enhancement A net-new feature or improvement to an existing feature and removed need/author-input Needs input from the original author labels Jan 28, 2022
@n0izn0iz n0izn0iz changed the title WIP - feat: sqlite support feat: sqlite support Jan 28, 2022
@n0izn0iz n0izn0iz merged commit f545048 into ipfs:master Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A net-new feature or improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants