This repository has been archived by the owner on Jun 27, 2023. It is now read-only.
Make switchToSharding more efficient #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When automatically switching a BasicDirectory to a HAMTDirectory because it grew too big, the current code: * loops every link in the BasicDirectory * reads each node referenced by those links * adds the nodes to a new HAMTDirectory shard, which in turn: * writes the nodes to the DAG service (they were just read from there!) * makes a link out of them (identical to the link in the BasicDirectory!) This would happen to about (~4000 nodes), which are fully read and written for nothing. This PR adds a new SetLink method to the HAMT Shard which, instead of taking an ipld.Node like Set(), takes directly an ipld.Link. Then it updates switchToSharding() to pass the links in the BasicDirectory directy, rather than reading all the nodes. Note that switchToBasic() works like this already, only using the links in the HAMT directory.
hsanjuan
commented
Jun 15, 2022
Comment on lines
+244
to
+246
| // FIXME: We don't need to set the name here, it will get overwritten. | ||
| // This is confusing, confirm and remove this line. | ||
| newLink.Name = ds.linkNamePrefix(0) + name |
There was a problem hiding this comment.
This is copy-pasted from Set() above.
aschmahmann
reviewed
Jun 16, 2022
| // given link. This avoids writing the given node, then reading it to making a | ||
| // link out of it. | ||
| func (ds *Shard) SetLink(ctx context.Context, name string, lnk *ipld.Link) error { | ||
| hv := newHashBits(name) |
There was a problem hiding this comment.
nit: Not required, but if in the future someone wants to extract this into reusable ds.SwapLink function for similar types of optimizations they can do so. Although it's really just a few copied lines of code.
|
Thank you for merging so quickly. |
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When automatically switching a BasicDirectory to a HAMTDirectory because it
grew too big, the current code:
This would happen to about (~4000 nodes), which are fully read and written for nothing.
This PR adds a new SetLink method to the HAMT Shard which, instead of taking
an ipld.Node like Set(), takes directly an ipld.Link. Then it updates
switchToSharding() to pass the links in the BasicDirectory directy, rather
than reading all the nodes.
Note that switchToBasic() works like this already, only using the links in the
HAMT directory.