This repository was archived by the owner on Jun 27, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 51
Make switchToSharding more efficient #120
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -229,6 +229,26 @@ func (ds *Shard) Set(ctx context.Context, name string, nd ipld.Node) error { | |
return err | ||
} | ||
|
||
// Set sets 'name' = nd in the HAMT, using directly the information in the | ||
// given link. This avoids writing the given node, then reading it to making a | ||
// link out of it. | ||
func (ds *Shard) SetLink(ctx context.Context, name string, lnk *ipld.Link) error { | ||
hv := newHashBits(name) | ||
|
||
newLink := ipld.Link{ | ||
Name: lnk.Name, | ||
Size: lnk.Size, | ||
Cid: lnk.Cid, | ||
} | ||
|
||
// FIXME: We don't need to set the name here, it will get overwritten. | ||
// This is confusing, confirm and remove this line. | ||
newLink.Name = ds.linkNamePrefix(0) + name | ||
Comment on lines
+244
to
+246
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is copy-pasted from Set() above. |
||
|
||
_, err := ds.swapValue(ctx, hv, name, &newLink) | ||
return err | ||
} | ||
|
||
// Swap sets a link pointing to the passed node as the value under the | ||
// name key in this Shard or its children. It also returns the previous link | ||
// under that name key (if any). | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Not required, but if in the future someone wants to extract this into reusable
ds.SwapLink
function for similar types of optimizations they can do so. Although it's really just a few copied lines of code.