This repository was archived by the owner on Sep 9, 2021. It is now read-only.
Feat/err codes #22
Merged
Feat/err codes #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned License: MIT Signed-off-by: Jacob Heun <jacobheun@gmail.com>
jacobheun
force-pushed
the
feat/err-codes
branch
from
0e09be4 to
75dd480
Compare
2 tasks
alanshaw
suggested changes
Sep 12, 2018
src/errors.js
Outdated
| module.exports.ERR_DB_CANNOT_OPEN = (err) => { | ||
| err = err || new Error('Cannot open database') | ||
| return errcode(err, 'ERR_CANNOT_OPEN_DB') | ||
| } |
There was a problem hiding this comment.
ERR_DB_OPEN_FAILED for consistency with the others?
src/errors.js
Outdated
| module.exports.ERR_NOT_FOUND = (err) => { | ||
| err = err || new Error('Not Found') | ||
| return errcode(err, 'ERR_NOT_FOUND') | ||
| } |
There was a problem hiding this comment.
Would it be better for these factory functions to be named more like dbDeleteError(), notFoundError()? All caps var names are by popular convention constant values and not functions.
There was a problem hiding this comment.
Updated the function names and the open failure code
License: MIT Signed-off-by: Jacob Heun <jacobheun@gmail.com>
alanshaw
approved these changes
Sep 12, 2018
|
@dignifiedquire it looks like you and @diasdavid are the only ones with publish permissions to npm for this repo. With him out until Friday would you be able to do a release of this so we can get js-ipfs#1557 resolved? |
This was referenced Sep 12, 2018
daviddias
approved these changes
Sep 17, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also updated the dependencies to their latest versions.
I have also run the updated tests locally against the error implementation in datastore-fs for reference. https://github.com/ipfs/js-datastore-fs/compare/feat/err-codes?expand=1 (note: the ci tests will fail there until the dependency is updated)