Skip to content
This repository was archived by the owner on Mar 23, 2023. It is now read-only.

feat: add basic error codes #14

Merged
merged 2 commits into from
Sep 18, 2018
Merged

feat: add basic error codes #14

merged 2 commits into from
Sep 18, 2018

Conversation

jacobheun
Copy link
Contributor

@jacobheun jacobheun commented Sep 12, 2018

Depends on ipfs/interface-datastore#22
Required by ipfs/js-ipfs#1557

This PR adds consistent error codes from the interface-datastore to allow downstream code to consistently handle datastore errors.

  • Update deps once interface-datastore#22 has been released

@ghost ghost assigned jacobheun Sep 12, 2018
@ghost ghost added the status/in-progress In progress label Sep 12, 2018
Copy link
Member

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jacobheun jacobheun requested a review from daviddias September 18, 2018 08:54
@jacobheun
Copy link
Contributor Author

The release of this will unblock the other datastores (fs, level, s3).

@daviddias daviddias merged commit 6d1ff31 into master Sep 18, 2018
@daviddias daviddias deleted the feat/err-codes branch September 18, 2018 23:23
@ghost ghost removed the status/in-progress In progress label Sep 18, 2018
@jacobheun
Copy link
Contributor Author

@diasdavid can we get a release of this? It's blocking the other datastore fixes. Thank you!

@daviddias
Copy link
Member

0.5.0 released

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants