Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test setup #50

Closed
dignifiedquire opened this issue Oct 5, 2015 · 4 comments
Closed

Add test setup #50

dignifiedquire opened this issue Oct 5, 2015 · 4 comments
Labels
help wanted Seeking public contribution on this issue P0 Critical: Tackled by core team ASAP

Comments

@dignifiedquire
Copy link
Member

Every decent (software) project needs tests

"Frontend" (browser processes)

This is about testing react components in isolation. To run the tests we should use karma and spawn a chrome process (close enough to electrons chromium instances). Interesting modules and notes

"Backend" (electron main process)

This is much harder, as too much functionality depends on running the real deal aka an electron instance. So very happy to hear any suggestions around this.

@daviddias daviddias added the help wanted Seeking public contribution on this issue label Nov 16, 2015
@daviddias daviddias mentioned this issue Dec 17, 2017
@hacdias
Copy link
Member

hacdias commented Jan 26, 2018

@hacdias
Copy link
Member

hacdias commented Jan 26, 2018

State of the thing: Taking this branch as the state from which we should start writing tests, we've got many different components to test:

  • components which Simple React components which seem to be relatively easy to test
  • controls which are subdivided in two:
    • main process handlers.
    • renderer process handlers.
  • panes which are a bit more complex React Components that can use Electron's API directly.
  • utils some simple... utils? Easy to test.
  • views main entry points for the pages Welcome and Menubar.
  • index.js, errors.js, config.js

I can easily start to create the tests for the components and the utils. Although, I'm not sure how to do testing for the controls, which are basically event handlers of ipcMain and some other general stuff. Nor for panes and views.

This was referenced Jan 27, 2018
hacdias added a commit that referenced this issue Jan 27, 2018
Make components as independent as possible
Remove repo.lock when not running (fix #588)
Fix #590 by using MFS
Save pins on MFS (ref.: #597)
Order addresses on info pane (fix #599)
Show previously pinned stuff (fix #600)
Save Screenshots on MFS
While daemon is turned off, let the user turn it on or close Desktop only.
Improve Files pane
Add some basic tests to start the testing journey #50
@hacdias hacdias added this to the v1.0 milestone Nov 22, 2018
@hacdias hacdias mentioned this issue Nov 22, 2018
15 tasks
@olizilla
Copy link
Member

olizilla commented Dec 5, 2018

WIP on adding spectron test in #730

@hacdias hacdias removed this from the v0.6 milestone Dec 21, 2018
@hacdias hacdias added the P0 Critical: Tackled by core team ASAP label Jul 24, 2019
@hacdias
Copy link
Member

hacdias commented Sep 13, 2019

Superseded by #1121

@hacdias hacdias closed this as completed Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Seeking public contribution on this issue P0 Critical: Tackled by core team ASAP
Projects
None yet
Development

No branches or pull requests

4 participants