-
Notifications
You must be signed in to change notification settings - Fork 864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pinned hashes don't show up #600
Comments
Thanks, that sounds great. Is there any way for me to get notified when that happens? |
Yeah, sure. I just can't give you a ETA about that PR. |
Alright, I just don't want to miss it. As long as you add to a mailing list or something. |
Make components as independent as possible Remove repo.lock when not running (fix #588) Fix #590 by using MFS Save pins on MFS (ref.: #597) Order addresses on info pane (fix #599) Show previously pinned stuff (fix #600) Save Screenshots on MFS While daemon is turned off, let the user turn it on or close Desktop only. Improve Files pane Add some basic tests to start the testing journey #50
Thanks, I'll download it. |
It still doesn't show hashes I've pinned through the command line. 😞 |
Let's reopen this then. I'll check it when I get back to my computer. |
@Cole128 right now, there are two issues I can identify that can be related to your problem:
|
@hacdias Ok, that sounds like it would cause my issue for sure. It should be recursive pins only, with the list updating every few seconds if you're on the pinned tab or update immediately when you switch to the tab, right? |
@Cole128 oops... I misspelled "not" and wrote "now". It was supposed to show recursive and direct pins right now. But it isn't refreshing at a constant rate. I'll open a PR for this and ask you to try it out 😄 |
@hacdias Alright, sounds great! Although I have a question about showing indirect pins: Why would you want to? My understanding is that indirect pins are just the hashes for blocks, the hashes for subsections of files that you've pinned. You can't access these hashes directly (you get an error), they are only for usage by the nodes. As a user, I find that they clutter a pinned list because I only want to see the hashes of the files I pinned, and seeing hashes I didn't pin in that list is confusing. |
@Cole128 yeah, it makes sense. So what I'm going to do is to refresh the pins every 1 or 2 seconds so it is always updated 😄 |
Alright, sounds good. When you said makes sense were you referring to what I was saying about indirect pins, or what I said about refreshing? |
Both 😄 |
Awesome! I love being able to help contribute to projects I like, and to actually talk to devs. Thank you for taking the time. Whenever you create the PR or a new version that fixes this, just send it my way and I'll happily test it out! |
I have just started using IPFS Desktop, and noticed that my pinned hashes weren't listed in the Pin tab. But when I run
ipfs pin ls
in the command line I get several hashes, including non-default ones. These hashes were pinned before I used IPFS desktop, but shouldn't it still see them?EDIT: I'd like to add that hashes pinned through IPFS desktop show up in the command line, just not the other way around. I'd like to also say that when I add a file, it doesn't show in the pin tab as well, even though files you add are automatically pinned.
The text was updated successfully, but these errors were encountered: