Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinned hashes don't show up #600

Closed
makew0rld opened this issue Jan 19, 2018 · 16 comments · Fixed by #596
Closed

Pinned hashes don't show up #600

makew0rld opened this issue Jan 19, 2018 · 16 comments · Fixed by #596

Comments

@makew0rld
Copy link

makew0rld commented Jan 19, 2018

I have just started using IPFS Desktop, and noticed that my pinned hashes weren't listed in the Pin tab. But when I run ipfs pin ls in the command line I get several hashes, including non-default ones. These hashes were pinned before I used IPFS desktop, but shouldn't it still see them?
EDIT: I'd like to add that hashes pinned through IPFS desktop show up in the command line, just not the other way around. I'd like to also say that when I add a file, it doesn't show in the pin tab as well, even though files you add are automatically pinned.

@hacdias
Copy link
Member

hacdias commented Jan 20, 2018

Hello @Cole128! I'm preparing a PR (#596) with a lot of bug fixes and I'll add this one to the list 😄 The problem is that, right now, we are using a file to match the tags to the hashes and only the hashes you pinned using Desktop will be on that file, but it will change soon!

@hacdias hacdias mentioned this issue Jan 20, 2018
10 tasks
@makew0rld
Copy link
Author

Thanks, that sounds great. Is there any way for me to get notified when that happens?

@hacdias
Copy link
Member

hacdias commented Jan 20, 2018

Yeah, sure. I just can't give you a ETA about that PR.

@makew0rld
Copy link
Author

Alright, I just don't want to miss it. As long as you add to a mailing list or something.
colecmac@gmail.com

hacdias added a commit that referenced this issue Jan 27, 2018
Make components as independent as possible
Remove repo.lock when not running (fix #588)
Fix #590 by using MFS
Save pins on MFS (ref.: #597)
Order addresses on info pane (fix #599)
Show previously pinned stuff (fix #600)
Save Screenshots on MFS
While daemon is turned off, let the user turn it on or close Desktop only.
Improve Files pane
Add some basic tests to start the testing journey #50
@makew0rld
Copy link
Author

Thanks, I'll download it.

@makew0rld
Copy link
Author

It still doesn't show hashes I've pinned through the command line. 😞

@hacdias
Copy link
Member

hacdias commented Jan 28, 2018

Let's reopen this then. I'll check it when I get back to my computer.

@hacdias hacdias reopened this Jan 28, 2018
@hacdias
Copy link
Member

hacdias commented Jan 28, 2018

@Cole128 right now, there are two issues I can identify that can be related to your problem:

  1. indirect pins are now not shown.
  2. The list isn't refreshed at a defined interval.

@makew0rld
Copy link
Author

@hacdias Ok, that sounds like it would cause my issue for sure. It should be recursive pins only, with the list updating every few seconds if you're on the pinned tab or update immediately when you switch to the tab, right?

@hacdias
Copy link
Member

hacdias commented Jan 28, 2018

@Cole128 oops... I misspelled "not" and wrote "now". It was supposed to show recursive and direct pins right now. But it isn't refreshing at a constant rate. I'll open a PR for this and ask you to try it out 😄

@makew0rld
Copy link
Author

makew0rld commented Jan 28, 2018

@hacdias Alright, sounds great! Although I have a question about showing indirect pins: Why would you want to? My understanding is that indirect pins are just the hashes for blocks, the hashes for subsections of files that you've pinned.

You can't access these hashes directly (you get an error), they are only for usage by the nodes. As a user, I find that they clutter a pinned list because I only want to see the hashes of the files I pinned, and seeing hashes I didn't pin in that list is confusing.

@hacdias
Copy link
Member

hacdias commented Jan 28, 2018

@Cole128 yeah, it makes sense. So what I'm going to do is to refresh the pins every 1 or 2 seconds so it is always updated 😄

@makew0rld
Copy link
Author

Alright, sounds good. When you said makes sense were you referring to what I was saying about indirect pins, or what I said about refreshing?

@hacdias
Copy link
Member

hacdias commented Jan 28, 2018

Both 😄

@makew0rld
Copy link
Author

Awesome! I love being able to help contribute to projects I like, and to actually talk to devs. Thank you for taking the time. Whenever you create the PR or a new version that fixes this, just send it my way and I'll happily test it out!

@hacdias
Copy link
Member

hacdias commented Jan 28, 2018

@Cole128 😃 Take a look at #606

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants