fix: refresh pins and stats at better rates

[hacdias]

Fixes #600.

Ping @Cole128

[makew0rld]

@hacdias Looks good 😄 , although will indirect pins show up? And how do I install it for my mac since it hasn't been packaged as a dmg yet?

[hacdias]

@Cole128 indirect pins won't show up. The only thing I added was the refreshing at every one sec.

About the .dmg:

When one of those little guys gets a check mark saying the build passed, you can click on Details --> Artifacts --> And there should be your dmg 😄

[makew0rld]

@hacdias Great! Once I install it and test it out I'll let you know whether it works.

[codecov-io]

Codecov Report

Merging #606 into master will decrease coverage by 0.1%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #606      +/-   ##
==========================================
- Coverage   15.21%   15.11%   -0.11%     
==========================================
  Files          57       57              
  Lines         874      880       +6     
==========================================
  Hits          133      133              
- Misses        741      747       +6

Impacted Files	Coverage Δ
src/controls/main/stats.js	0% <0%> (ø)	⬆️
src/screens/menubar.js	0% <0%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c27f22d...e2c7ce2. Read the comment docs.

[makew0rld]

@hacdias I can't open the dmg, it says image not recognized.

[hacdias]

Could you try on the other link? I don't have a macOS and I can't really help with that but please try the other link. Otherwise, tomorrow I can try to make it rebuild the image.

[makew0rld]

@hacdias I tried both.

[victorb]

@Cole128 could you please comment with the exact link you downloaded the .dmg from and also what macOS version you're running?

[makew0rld]

@victorbjelkholm https://ci.ipfs.team/job/IPFS%20Shipyard/job/ipfs-desktop/job/update-pin/1/artifact/out/make/IPFS%20Desktop-0.3.0.dmg
and https://ci.ipfs.team/job/IPFS%20Shipyard/job/ipfs-desktop/job/PR-606/1/artifact/out/make/IPFS%20Desktop-0.3.0.dmg

I am running macOS High Sierra, version 10.13.2 (17C88)

[hacdias]

@Cole128 Could you try this one?

---

Just as a sidenote: builds are failing due to sinonjs/nise#27

[ghost]

Calling pin/ls once per second can cause quite the load on go-ipfs and the harddrive. Is it really neccessary to have this happen every second?

If live updates are neccessary, we could instead emit pin-added and pin-removed events (we might already be doing that), which ipfs-desktop could listen to.

[ghost]

we could instead emit pin-added and pin-removed events

To clarify, I mean the ipfs log command.

[hacdias]

@lgierth didn't know about that!! Thanks. I'll check that out and see what if there are any events related to the pins.

[ghost]

About the proposed code in this PR, it looks like it'll fire another pin/ls command no matter if the previous one has returned already. This means you can end up with multiple in-flight pin/ls commands, causing additional load. You should queue the next command only once the current one has returned. That way slow responses are treated as back-pressure.

[hacdias]

@lgierth yeah, I've noticed that before lunch and I'm planning to change it to only call the command again one second after having the other's response.

How should I listen to those events? Using ipfs.log.tail([callback])? It seems a bit impractical since it doesn't allow me to handle specific event types.

[ghost]

Mh it looks like the ipfs log command is quite odd -- it seems like ipfs log tail lets deals with events, but ipfs log ls and ipfs log level deal with log output. (Events and log output are two different things).

Maybe a filter argument to ipfs log tail is neccessary, or just moving the events stuff into its own command.

[hacdias]

@Cole128 here's a new dmg!

[makew0rld]

@hacdias I still get the error: Image not recognized.
Do any of you guys have a mac to test it out on?

[hacdias]

@Cole128 unfortunately, I don't. Maybe @lgierth?

[hacdias]

I'll merge this for now and then we can try to check out what's happening with the DMG.