-
Notifications
You must be signed in to change notification settings - Fork 864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: monochrome tray icon on Windows & Linux #2159
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On Linux, I don't think we've ever had the conversation of supporting both light and dark themes. Therefore, it was just something we missed.
We did not touch this on Linux because (afaik) there is no standard API for this that works across Linux ecosystem. Linux people use different DE and using the colored icon is safer.
As a data point, the icon is invisible on old school black i3bar:
@hacdias mind restoring old behavior (colored icon) on Linux?
Instead, can we include a setting for this and default linux to the colored icon? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM but we should resolve the linux tray icon discussion
I think this is also a great idea: just give users a simple option to either use colored or B&W. |
@lidel do you agree with us? #2159 (comment) Do you see any problems with this? |
I don't feel super strong about this, my default mindset is to avoid adding niche features that increase maintenance cost, but this is small enough that it should be fine. |
need to wait for change: Instead, can we include a setting for this and default linux to the colored icon?
@hacdias can you confirm if you were planning on implementing the
|
b5e8b32
to
ee30ede
Compare
786e92a
to
e605016
Compare
@SgtPooki I updated the PR such that a new option shows under Settings on Windows and Linux. By default, we keep the current behavior (colored icons), but users are free to choose if they want monochromatic icons or not. Having a different default for Windows and Linux would involve further changes, to which I don't have bandwidth right now. Tested on macOS (to check if the behavior is kept) and Windows (it works fine). You can see the last commit for this changes only. |
e605016
to
5cdd914
Compare
This addresses #956 by adding monochrome tray icons for the remaining platforms (Windows and Linux). This way, we are consistent cross-platform and consistent with the platforms themselves.
Background, or, why did we not do this before?:
Screenshots on Windows:
@lidel @SgtPooki I would not consider this a priority. However, I would like to ask you to test this on any Linux platform you have in hand to check if it behaves correctly. If not, we can keep the colored icons for the time being.