-
Notifications
You must be signed in to change notification settings - Fork 865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tray Icon - Colors, more info? #956
Comments
The same "dark" and "light" icon variants could be used in ipfs-companion in Firefox |
+1 to following the apple guidelines and using a monochromatic "template image" for the menu bar. |
@ericronne any suggestion to distinguish between an online and offline node with a monochromatic image? |
Taking a 👀now! |
@hacdias do you know the size parameters? In order to make this look the best, i may want to recreate it on a pixel grid. Also what format would you like? thx! |
This comment has been minimized.
This comment has been minimized.
Yes! |
The sizes I gave you are for IPFS Desktop and they must contain padding. Trust me on the sizes! You have an high-dpi screen (2x) that's why you measure 44px and not 22px which is the base 😃 |
For IPFS Companion I don't know. @lidel must know :) |
Also, the template images must be only black and alpha channel. The grays must be made of alpha changes in the black color. Just a FYI if you didn't know 😃 |
How do the |
Also where are the |
The big ones are for Windows and Linux - you can make them a bit smaller if you want. Anyways if you're using something vectorial, we just need to export to the right sizes. Not really a big deal. 😄 A note about template files: all colours must be a mix of black and opacity! Using grays will only make an opaque image that doesn't work. Just black and alpha. The non-template ones are coulored. |
@ericronne if you're using Sketch and if it makes it easier for you, you can just send me the Sketch file with all artboards (on/off black&alpha/coloured) and I can export them to the right sizes. |
I think i need to better understand where each of the images will be displayed. My new design is really best suited to very small implementations. Is there a way for me to see where each icon is used, so i can get the proper context? Sorry, i'm guessing that could be a lot of legwork for you. 😬 And yep, i'm creating vectors in sketch. Black fills, alphas for "gray." |
This comment has been minimized.
This comment has been minimized.
@ericronne so I have been trying and experiment and I've got the right sizes I need! Please let me know if you have any doubts. This icons will only be used macOS menubar, Windows system tray and Linux app indicator/menubar. For macOSOn macOS, the icons must include padding. The base size is 22x22px which is the size of a 'square' in the menubar. The current offline icon. So, the files for macOS are:
The same for For WindowsOn Windows, on the other hand, the base size is 16x16px and they must not contain padding. Of course it can contain some horizontal padding if needed to fit the 16 pixels. Here I need an
If you cannot provide an
Same for For other OSesJust provide a |
Ok! Here's a full set.
|
@ericronne not a major thing, but since I didn't know if I have permission to edit the Sketch file, the coloured ones must not have the 'Template' part on the name: I have made some updates on the sizes here: Using your sketch file, I can get all of those, I'll see how they look and update you later. |
Removed |
@ericronne I really like semicircles as indicator. ps. The badge with a number will probably go away (we will display only the icon). |
Ah. So how do the other logos in the screenshots know which art to apply? |
@ericronne good question. Can't find any info about it, but those icons are from the Operating System itself. There might be a way to support it, but Electron doesn't support it right now (I've opened an issue about that). |
No problem, you can just update the sketch file and let me know. That way I can easily export to the right sizes. On macOS they look great, as usual:
On Windows: My opinions
What I think we should do
|
I like the icon with added connectivity dots at bigger sizes, but I start to think it won't work in small size. If we look at what other brands did at those very small sizes, they simplified their icon and kept only the minimum, making it easier for people to find it. We are adding stuff, which makes it harder to recognize the icon. What if we go with a bigger, simple bw IPFS cube alone? Some ideas:
ps. just noticed unfotunate similarity to https://github.com/features/package-registry/signup: 🙃 |
Thanks so much for your patience to date @hacdias ❤️! Yes simpler seemed wise to me, too. Files representing a less detailed take on the windows icons are on the drive. The sketch file is there, too. Windows …
It does lack weight / gravitas, primarily because the border (added since we can't detect whether the user has chosen light or dark mode) forces us to reduce the size of the icon. Alternatively, we could apply color, but to me, color makes the icon feel less professional, more "slapped on." Black and white aligns with the system-level icons, and consequently inherits some of their authority. I'm afraid i've invested too many hours in this project. If we think further work is needed, i can help find an outside resource. Icon design is a highly specific craft; a ton of eficianados are on dribble, eg. We can reach out to one or two whom we like, if need be. And re github, this is one danger of using a hexagonal logo for tech products of this type: it's going to look like someone else's logo, sigh. Thanks, all! |
I finally got annoyed enough seeing only colored icon in my menubar that I decided to submit an issue & found out that it's already being worked on. Thanks folks for driving this effort! I would like to offer some, hopefully constructive, feedback / opinion. Version 1I did not like the first version. I won't go into details as I think conversation had moved on from it. I think just doing what Dropbox does would have being a better option. Version 2I do like this version. However I seem to interpret visual signals other way round from their intention. Node is isolated / Fragmented network / Node is behind NAT or Firewall can't reach othersNode discovered other peers / Node is part of larger networkAdditionally I find that running (which I interpret incorrectly) to be more complex than the other version & I think it's better to optimize for for the version that we expect people to see most of the time, meaning more clean / simple version. Even though I do like this version, I do find them in small sizes (like in browser toolbar) to be to complex & heavy on eyes. Version 3I think I preferred version 2 better, difference between on / off states is more evident via glance than in this version (cube is enclosed / cube is no longer enclosed vs enclosure become dashed). This new icons led me to following idea what if running version was just a cube and not running version was dashed cube (kind of like enclosure in the version 3). Here is my humble attempt to visualize it (I think making lines even smaller might make difference even more apparent but that's beyond my drawing skill level) IPFS is running (Connected to other peers / nodes in the network)IPFS is not running (Disconnected from other peers / nodes in the network)IPFS is starting (Connecting to other peers / nodes in the network) |
I'm personally annoyed by the coloured icon too and, in my opinion, even if we do not change it on other OSes, I think we should do so on macOS since that's the default and the recommended guidelines given by Apple. On Windows in particular, users are used to see tons of colored icons on their taskbar so I don't think this would be such an issue. @Gozala specifically about your opinions about the second version: I understand them, but I wouldn't interpret the pictures as you did haha. Also, what we need here is more of a way to distinguish between running and not running and not if we're connected to someone. At least, for now. We've had this discussion previously but, unfortunately, we haven't came to a decision yet. Although I don't find this a priority, I would be very happy if we got nice looking icons for this. |
To be clear I did not meant to suggest it was the "right way" to interpret it, merely that some people can read those signals differently. |
BTW I just noticed that "iCloud Drive" uses similar visual signals to one I proposed in #956 (comment) by displaying "cloud trace" next to files that are not replicated in the cloud yet (Once it is up it disappears). That is to suggest that solid edge cube and traced cube edge is going to be somewhat familiar pattern that later could probably become useful once MFS mounts are further along. |
@Gozala honestly, I wouldn't mind and I kinda like it: simple and really easy to understand. I'd also to get more feedback from @lidel and @ericronne on this: even if we don't implement it on other OSes right now, I think it would be great to have on macOS. |
I'm ok with OS-specific icons. This is similar to doing translations: does not need to be 1:1, a priority is to make things look and feel natural (native) in the target environment. Personally, I really like the simplicity of and (animation is 👌), should work pretty well at small sizes. I would like to see how they look like in white on dark background (mac menubar), especially the dotted one when dimmed 🤔 |
What I understood was that if we used the dotted one, we wouldn't dim it when the node is offline. Am I wrong? And yes, I think we should make the icons for macOS. @ericronne would you be available to take a look at these? |
Yes I was suggesting to have dotted version for not running state and solid one for running state, so no dimming. Although that was merely a suggestion and @lidel might have something else in mind |
+1 for simplicity, provided the icon holds its own on the bar. Animation to indicate "starting" would be great. I didn't know that was an option; have y'all seen others use it? If we go with that, a timeout feature of some kind might help insure that it doesn't get annoying. If we kept the dots when the box turned solid, that might help make the "running" state look less generic |
yas! Docker uses a pretty nice animation on the menubar while booting up! Don't know how easy it is to do with Electron though.
I like it!
Enjoyed the pun! |
oh yeah, docker! 🐳 |
Let's keep it simple now and move on this :D |
I think we should close this issue for now as #1256 was merged. We now have a compliant icon for macOS. Windows does not have any guidelines or way to know if we're using a dark or light theme so the icon can be used. |
Right now, IPFS Desktop tray icon is coloured. That goes against some guidelines and "what we usually" see on macOS. If we notice, when using the dark theme, we get white icons, and when using the light theme, we get dark/coloured icons.
The same applies for the most recent version of Windows 10, where there are effectively two themes (light and dark). System icons honour that, although since it is a really recent thing, most apps don't.
I think we could provide a coloured icon and a black and white version. By default, it would honour the system settings (dark or light theme) and we could let the user choose if they want a coloured icon or not in settings (like Mullvald does).
Also, we could expand our icon to show some interesting features. @daviddias has suggested, on ipfs/ipfs-webui#1048 (comment), the following:
Despite our cube only having three faces, surely not most of the experiments/features deserve to be "shown off" on the icon. Some of them could be js-ipfs (#601) and npm-on-ipfs (#911).
/cc @ipfs-shipyard/gui @daviddias
The text was updated successfully, but these errors were encountered: