Skip to content

fixed all eslint warnings in root #2378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
SgtPooki merged 3 commits into from
Jul 23, 2025
Merged

fixed all eslint warnings in root #2378

SgtPooki merged 3 commits into from
Jul 23, 2025

Conversation

@Pfed-prog
Copy link
Contributor

@Pfed-prog Pfed-prog commented May 28, 2025 •
edited
Loading

@Pfed-prog Pfed-prog requested a review from a team as a code owner May 28, 2025 04:00
@welcome
Copy link

welcome bot commented May 28, 2025

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines
    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

@Pfed-prog
Copy link
Contributor Author

Pfed-prog commented Jun 4, 2025

@SgtPooki any chance you could provide feedback or a review?

SgtPooki
SgtPooki suggested changes Jun 4, 2025
View reviewed changes
Copy link
Member

@SgtPooki SgtPooki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some CI is failing

@Pfed-prog
Copy link
Contributor Author

Pfed-prog commented Jun 4, 2025

Thanks for running CI, I did not expect to find new warnings. Fixing newly found errors.

@Pfed-prog
Copy link
Contributor Author

Pfed-prog commented Jun 4, 2025

Excuse me for being annoying @SgtPooki. I have run npm run lint typecheck and dep-check locally pass.

@SgtPooki
Copy link
Member

SgtPooki commented Jun 4, 2025

Excuse me for being annoying @SgtPooki. I have run npm run lint typecheck and dep-check locally pass.

🤣 no worries, thanks for opening an issue and submitting a fix for it! not a problem at all.. clicking "run CI jobs" is the easiest thing I've done today 😛

SgtPooki
SgtPooki approved these changes Jul 23, 2025
View reviewed changes
@types/ipfs/index.d.ts
declare module 'ipfs' {
import type { CID } from 'multiformats/cid'
import type { Multiaddr } from '@multiformats/multiaddr'
import type { Buffer } from 'buffer'
Copy link
Member

@SgtPooki SgtPooki Jul 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are a ton of changes here, but after checking a majority of these it looks like it's just a re-arranging of the types.

I would really like to remove this entire file and depend solely on kubo-rpc-client types

@SgtPooki SgtPooki merged commit 0e9fe55 into ipfs:main Jul 23, 2025
20 checks passed
@SgtPooki SgtPooki mentioned this pull request Jul 23, 2025
Merged
ipfs-gui-bot pushed a commit that referenced this pull request Aug 7, 2025
@semantic-release-bot
chore(release): 4.8.0 [skip ci]
59ec535 
## [4.8.0](v4.7.0...v4.8.0) (2025-08-07)

 CID `bafybeifplj2s3yegn7ko7tdnwpoxa4c5uaqnk2ajnw5geqm34slcj6b6mu`

 ---

### Features

* add async provide on share/copy/pin/ipns ([#2387](#2387)) ([cfea7d4](cfea7d4))

### Bug Fixes

* eslint doesnt check build folder ([#2389](#2389)) ([2a6c64a](2a6c64a))
* refresh stale multiaddrs on the Status page ([#2385](#2385)) ([6c361c4](6c361c4))
* stop sending requests to defunct countly ([#2395](#2395)) ([fb9c981](fb9c981)), closes [#2334](#2334)

### Trivial Changes

* fix all eslint warnings in root ([#2378](#2378)) ([0e9fe55](0e9fe55))
* Pull transifex translations ([#2364](#2364)) ([424c8a8](424c8a8))
* Pull transifex translations ([#2384](#2384)) ([575da08](575da08))
* Pull transifex translations ([#2386](#2386)) ([9a78d5f](9a78d5f))
@ipfs-gui-bot
Copy link
Collaborator

ipfs-gui-bot commented Aug 7, 2025

🎉 This PR is included in version 4.8.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@SgtPooki SgtPooki SgtPooki approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Pfed-prog @SgtPooki @ipfs-gui-bot