fix: eslint doesnt check build folder #2389
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Fixes issues found after merging #2378 |
ipfs-gui-bot
pushed a commit
that referenced
this pull request
Aug 7, 2025
## [4.8.0](v4.7.0...v4.8.0) (2025-08-07) CID `bafybeifplj2s3yegn7ko7tdnwpoxa4c5uaqnk2ajnw5geqm34slcj6b6mu` --- ### Features * add async provide on share/copy/pin/ipns ([#2387](#2387)) ([cfea7d4](cfea7d4)) ### Bug Fixes * eslint doesnt check build folder ([#2389](#2389)) ([2a6c64a](2a6c64a)) * refresh stale multiaddrs on the Status page ([#2385](#2385)) ([6c361c4](6c361c4)) * stop sending requests to defunct countly ([#2395](#2395)) ([fb9c981](fb9c981)), closes [#2334](#2334) ### Trivial Changes * fix all eslint warnings in root ([#2378](#2378)) ([0e9fe55](0e9fe55)) * Pull transifex translations ([#2364](#2364)) ([424c8a8](424c8a8)) * Pull transifex translations ([#2384](#2384)) ([575da08](575da08)) * Pull transifex translations ([#2386](#2386)) ([9a78d5f](9a78d5f))
Collaborator
|
🎉 This PR is included in version 4.8.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FYI that eslint was passing in CI because it runs before build, but when running locally i was getting hundreds of thousands of errors.. debugging with
DEBUG=eslint:cli-engine npm run eslintshowed that the build folder was being checked. when I removed that, it started succeeding again.Also removed the ignoring of .ts files in the
.eslintrc.cjsfile