Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename zh locale code to match Transifex #784

Merged
merged 1 commit into from
Sep 7, 2018
Merged

Rename zh locale code to match Transifex #784

merged 1 commit into from
Sep 7, 2018

Conversation

lidel
Copy link
Member

@lidel lidel commented Sep 7, 2018

This PR applies changes from ipfs/ipfs-gui#50 (comment) and fixes rendering of Chinese version.

I smoke tested this PR and strings that are already translated rendered correctly:

screenshot_45

@lidel lidel requested review from olizilla and hacdias September 7, 2018 12:57
olizilla
olizilla approved these changes Sep 7, 2018
View reviewed changes
Copy link
Member

@olizilla olizilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable while we don't have more specific zh translations.

@lidel lidel merged commit 3fd0e0c into revamp Sep 7, 2018
@lidel lidel deleted the fix/chinese-translation branch September 7, 2018 13:28
@lidel lidel restored the fix/chinese-translation branch September 8, 2018 19:00
@lidel lidel mentioned this pull request Sep 8, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olizilla olizilla olizilla approved these changes

@hacdias hacdias Awaiting requested review from hacdias

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lidel @olizilla