-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add file operations in preview #936
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This reverts commit b6de686.
@fsdiogo I'm not sure why we're seeing so many changes to the package-lock.json... can you talk me through your workflow? This is probably all super obvious, but I want to share steps we go through when devloping to see if there are differences that might explain it. When trying out a branch i tend to just run: git checkout <branch>
npm install
npm start and that doesn't typically lead to a change in the package-lock.json (though it does on occasion, would be great to figure out why) When adding a dep while working on a branch, i run npm install <dep> and that updates both the In this PR, there is no change to the At this moment, there are bunch of updates to ipld that we can't pull in until we do a bunch of work to update ipld-explorer-components. There are some other transitve deps in our tree that seem to regularly causes issues, something around level.js and leveldown. changes to them in the package-lock regularly cause build failures, so I'm being extra cautious about changes to the |
That is my workflow. Although when I check out to a new branch and install the deps the What happened in the last two commits was that I removed the |
@fsdiogo I hear you. When the package-lock does change without me editing the package.json, i've either been resetting it with a The general pattern I'm following is, if the |
I'll get the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 😄
@fsdiogo this looks good, but there is a rendering issue in firefox Please remember to check things in at least Chrome and Firefox! We need to wire up a service to automate the cross-browser testing, but in the meantime, it's on us. |
Closes #813.