Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: extend dropzone to page #942

Merged
merged 15 commits into from
Jan 24, 2019
Merged

feat: extend dropzone to page #942

merged 15 commits into from
Jan 24, 2019

Conversation

fsdiogo
Copy link
Contributor

@fsdiogo fsdiogo commented Jan 18, 2019

  • The dropzone was extended to the whole page
  • We can now drop a file in any page: it is added to the root folder and the user redirected to the files page
  • In the files page we can still drop the files in specific folders as before

dropit

Closes #916.

@fsdiogo fsdiogo self-assigned this Jan 18, 2019
@ghost ghost added the status/in-progress In progress label Jan 18, 2019
@fsdiogo
Copy link
Contributor Author

fsdiogo commented Jan 18, 2019

This is a branch of #936, so that should be merged first.

hacdias
hacdias approved these changes Jan 20, 2019
View reviewed changes
Copy link
Member

@hacdias hacdias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works beautifully here. 😄 It seems that Jenkins is failing due to some "internal" issues so I think we don't need to worry about it for now.

olizilla
olizilla approved these changes Jan 24, 2019
View reviewed changes
Copy link
Member

@olizilla olizilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 works well!

For a future PR, it'd be nice to extract the dropzone to a component that we can import into the App.js

@fsdiogo fsdiogo merged commit 09f6de9 into master Jan 24, 2019
@ghost ghost removed the status/in-progress In progress label Jan 24, 2019
@fsdiogo fsdiogo deleted the feat/extend-dropzone-to-page branch January 24, 2019 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olizilla olizilla olizilla approved these changes

@hacdias hacdias hacdias approved these changes

Assignees

@fsdiogo fsdiogo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fsdiogo @olizilla @hacdias