Added missing npmignore #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
🌟 @JGAntunes thank you for catching this. @dignifiedquire @nginnever looks like the other dignified PRs have to be changed :) |
| # Optional REPL history | ||
| .node_repl_history | ||
|
|
||
| dist |
There was a problem hiding this comment.
dist should not be in here, we want that to be published as well!
cc @diasdavid
|
@dignifiedquire @diasdavid sorry, didn't realise that. I can submit another PR to fix this if you think it's worth it. |
|
@JGAntunes that would be great thanks |
achingbrain
pushed a commit
that referenced
this pull request
Feb 19, 2020
README and API improvements
achingbrain
added a commit
that referenced
this pull request
Feb 19, 2020
perf: deep require pull stream modules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If I understood the dignified pipeline correctly I think you need a
.npmignorefile, as the lack of it implies that, by default, npm publish will use.gitignorewhich will leave out/libpath.Basically I've copy pasted the .gitignore file, leaving out files npm already ignores by default and the
/libpath.