This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
Fixed issues with some required modules #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It also seems to me that the current build is failing due to this - ipfs/js-ipfs-unixfs#8 |
|
LGTM |
| @@ -3,7 +3,7 @@ const debug = require('debug') | |||
| const path = require('path') | |||
| const log = debug('cli:config') | |||
| log.error = debug('cli:config:error') | |||
| const utils = require('utils') | |||
| const utils = require('../../utils') | |||
There was a problem hiding this comment.
how was this not failing before? Could you add a test too @JGAntunes ? Thank you!
//cc @xicombd
There was a problem hiding this comment.
No idea, I'll try to review the config commands later today, I think they're not working with the daemon running either 😟
There was a problem hiding this comment.
@diasdavid sure thing, will look at it later today also, so maybe I can help you out @xicombd.
|
build is green now (for this branch as well), let me know if it is working for you. |
|
Seems good to me, I can now install and run the cli. |
This was referenced Jan 20, 2022
This was referenced Mar 21, 2022
This was referenced Apr 7, 2022
This was referenced Nov 27, 2023
This was referenced Nov 28, 2023
This was referenced Feb 11, 2024
This was referenced Feb 11, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to install and run ipfs I ran into some troubles, this should fix some of it.