Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

Exchange Files Example: Show room feature #1632

Closed
daviddias opened this issue Oct 13, 2018 · 0 comments · Fixed by #1949
Closed

Exchange Files Example: Show room feature #1632

daviddias opened this issue Oct 13, 2018 · 0 comments · Fixed by #1949
Labels
example exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue P3 Low: Not priority right now

Comments

@daviddias
Copy link
Member

image

Currently, it is impossible to guess that there is the room feature on the exchange files example. It would be great to add a label at the top of the website of "create room"
@alanshaw alanshaw added exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue status/ready Ready to be worked P3 Low: Not priority right now example labels Oct 15, 2018
@niinpatel niinpatel mentioned this issue Mar 19, 2019
Merged
alanshaw pushed a commit that referenced this issue Apr 4, 2019
@niinpatel
docs: add rooms feature to examples/exchange-files (#1949)
08b6740 
As mentioned in issue #1632, currently, it is impossible to guess that there is the room feature on the exchange files example.

So, I added a textbox and a button which can be used for subscribing to a different room. Here's a small preview of the feature: 

![ipfs rooms demo (2)](https://user-images.githubusercontent.com/31539366/54750766-d7742400-4bfe-11e9-825c-7b0ff6007c8a.gif)

closes #1632 

License: MIT
Signed-off-by: Nitin Patel <nitinpatel278@gmail.com>
@ghost ghost removed the status/ready Ready to be worked label Apr 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
example exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue P3 Low: Not priority right now
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Show room feature in Exchange Files Example niinpatel/js-ipfs
2 participants
@alanshaw @daviddias