feat: gossipsub as default pubsub #2298

vasco-santos · 2019-07-24T15:46:40Z

Needs:

Add selection to config
New release js-libp2p with libp2p/js-libp2p#365
ipfs/interface-js-ipfs-core#503

jacobheun · 2019-07-31T08:05:23Z

@vasco-santos fyi, I pushed up a version bump to the new libp2p RC and also fixed the pubsub methods to correct the breaking changes.

jacobheun · 2019-07-31T08:06:13Z

Since we've changed how pubsub is registered, we'll need to release this with the update of libp2p

vasco-santos · 2019-07-31T08:16:37Z

Thanks @jacobheun

vasco-santos · 2019-07-31T08:22:49Z

We also need to change the gossipsub version and update the bundle size. I will do it

jacobheun · 2019-07-31T11:55:44Z

I missed 1 subscribe call, that's been corrected. It's 🍏 !

vasco-santos · 2019-07-31T12:00:18Z

thanks for looking into this @jacobheun

@alanshaw this is ready for you to have a look
also @jacobheun if you want to check the config part of the things in the PR, if you did not

doc/config.md

package.json

src/core/components/libp2p.js

src/core/components/pubsub.js

src/core/config.js

src/core/runtime/config-browser.js

src/core/runtime/config-nodejs.js

test/core/libp2p.spec.js

alanshaw · 2019-08-28T08:37:51Z

@vasco-santos interface-ipfs-core@0.111 has been released.

alanshaw · 2019-08-28T08:38:41Z

.aegir.js

@@ -8,7 +8,7 @@ const ipfsdServer = IPFSFactory.createServer()
 const preloadNode = MockPreloadNode.createNode()

 module.exports = {
-  bundlesize: { maxSize: '689kB' },
+  bundlesize: { maxSize: '694kB' },


Hopefully this can stay the same if we're not bundling 2 implementations?

alanshaw · 2019-08-28T09:24:57Z

FYI I have updated ipfs-inactive/js-ipfs-http-client#1059 to support string data in pubsub.publish so don't worry about sending a separate PR!

README.md

vasco-santos · 2019-08-28T14:14:29Z

@alanshaw I think that I addressed everything from your review

alanshaw

There still seems to be references to EXPERIMENTAL.pubsub in the code (including the examples). Can you make sure these are all fixed?

vasco-santos · 2019-08-31T13:32:22Z

package.json

-    "interface-ipfs-core": "^0.110.0",
-    "ipfsd-ctl": "^0.44.1",
+    "interface-ipfs-core": "^0.111.0",
+    "ipfsd-ctl": "ipfs/js-ipfsd-ctl#fix/pubsub-flag-defaults",


@alanshaw @hugomrdias we have a circular dependency issue here with ipfsd-ctl:

ipfs/js-ipfsd-ctl#363

Why not just have --enable-pubsub as the official option name and create an alias as --enable-pubsub-experiment?

So, are you recommending to alias here, and use in the tests --enable-pubsub-experiment for now?

Anyway, I need the ctl to do: https://github.com/ipfs/js-ipfsd-ctl/pull/363/files#diff-d06a3c390787c7b35d2ab649265df1bbR50

should i merge/release that PR as is ?

If we do, we cannot delete this branch. But it is the only way to get CI green. My main concern is that we need to wait for the js-ipfs release 😡

we can point to master or a commit until the release

I am ok with merging that, and take the AI of PR ctl to use master once this PR is merged

ctl released as 0.45.0

vasco-santos · 2019-08-31T22:15:48Z

Also, I am having issues with dns tests in browser. The same is occurring in master though

alanshaw · 2019-09-02T17:20:00Z

@vasco-santos I had to revert the upgrade of ipfs-http-client in master because it allows string messages so you'll need to update it here.

vasco-santos · 2019-09-02T18:24:32Z

As talked with @alanshaw , I skipped the dns tests which are currently failing due to a gateway issue (not related to this). I will create a new PR to enable them as soon as this is merged

vasco-santos force-pushed the feat/gossipsub-as-default-pubsub branch 6 times, most recently from 448bfed to 6a47db6 Compare July 26, 2019 13:26

vasco-santos force-pushed the feat/gossipsub-as-default-pubsub branch from 0315c72 to b66463b Compare July 31, 2019 08:26

jacobheun force-pushed the feat/gossipsub-as-default-pubsub branch 2 times, most recently from 19573fe to e99c57d Compare August 9, 2019 10:51

jacobheun marked this pull request as ready for review August 19, 2019 16:54

jacobheun requested a review from alanshaw August 19, 2019 16:54

jacobheun force-pushed the feat/gossipsub-as-default-pubsub branch from e99c57d to 7b9d66f Compare August 21, 2019 17:58

alanshaw mentioned this pull request Aug 27, 2019

⚡️ v0.38.0 RELEASE 🚀 #2396

Closed

66 tasks

alanshaw suggested changes Aug 28, 2019

View reviewed changes

alanshaw mentioned this pull request Aug 28, 2019

Update libp2p to the latest version 🚀 #2342

Closed

alanshaw reviewed Aug 28, 2019

View reviewed changes

alanshaw mentioned this pull request Aug 28, 2019

Update interface-ipfs-core to the latest version 🚀 #2400

Closed

vasco-santos force-pushed the feat/gossipsub-as-default-pubsub branch from 7b9d66f to aa2eb36 Compare August 28, 2019 12:26

vasco-santos commented Aug 28, 2019

View reviewed changes

README.md Show resolved Hide resolved

vasco-santos force-pushed the feat/gossipsub-as-default-pubsub branch from aa2eb36 to 8f3dcaa Compare August 28, 2019 12:50

alanshaw suggested changes Aug 28, 2019

View reviewed changes

vasco-santos force-pushed the feat/gossipsub-as-default-pubsub branch from 8f3dcaa to 011827d Compare August 31, 2019 12:42

vasco-santos mentioned this pull request Aug 31, 2019

fix: pubsub flag defaults ipfs/js-ipfsd-ctl#363

Merged

vasco-santos commented Aug 31, 2019

View reviewed changes

vasco-santos force-pushed the feat/gossipsub-as-default-pubsub branch 2 times, most recently from a30d22d to c21d362 Compare August 31, 2019 13:57

alanshaw mentioned this pull request Sep 2, 2019

revert: update of ipfs-http-client #2412

Merged

vasco-santos force-pushed the feat/gossipsub-as-default-pubsub branch 2 times, most recently from 2e44237 to 8f56488 Compare September 2, 2019 17:00

vasco-santos and others added 11 commits September 2, 2019 19:51

feat: gossipsub as default pubsub

0bdc701

chore: add config for pubsub router

679c409

chore: increase max bundle size

de89e4d

fix: correct pubsub methods for next libp2p release

406563e

fix(pubsub): subscribe call to libp2p

c80e942

chore: update gossipsub and libp2p

a9b41e1

test: fix libp2p config test

fa38df7

chore: update libp2p

85d66d7

chore: address review

ee837cf

chore: address review

f02da5c

chore: skip dns tests

60c732a

vasco-santos force-pushed the feat/gossipsub-as-default-pubsub branch from 8f56488 to 60c732a Compare September 2, 2019 18:17

alanshaw approved these changes Sep 2, 2019

View reviewed changes

alanshaw merged commit 902e045 into master Sep 2, 2019

alanshaw deleted the feat/gossipsub-as-default-pubsub branch September 2, 2019 20:39

alanshaw mentioned this pull request Sep 2, 2019

Update interface-ipfs-core to the latest version 🚀 #2409

Closed

This was referenced Sep 2, 2019

chore: unskip dns tests #2417

Merged

chore: update ipfs dep ipfs/js-ipfsd-ctl#364

Merged

snyk-bot mentioned this pull request Dec 6, 2019

[Snyk] Upgrade ipfs from 0.37.1 to 0.39.0 dyna-dot/orbit-web#1

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: gossipsub as default pubsub #2298

feat: gossipsub as default pubsub #2298

vasco-santos commented Jul 24, 2019 •

edited by alanshaw

Loading

jacobheun commented Jul 31, 2019

jacobheun commented Jul 31, 2019

vasco-santos commented Jul 31, 2019

vasco-santos commented Jul 31, 2019 •

edited

Loading

jacobheun commented Jul 31, 2019

vasco-santos commented Jul 31, 2019 •

edited

Loading

alanshaw commented Aug 28, 2019

alanshaw Aug 28, 2019

alanshaw commented Aug 28, 2019

vasco-santos commented Aug 28, 2019

alanshaw left a comment

vasco-santos Aug 31, 2019 •

edited

Loading

alanshaw Sep 2, 2019

vasco-santos Sep 2, 2019

vasco-santos Sep 2, 2019

hugomrdias Sep 2, 2019

vasco-santos Sep 2, 2019

hugomrdias Sep 2, 2019

vasco-santos Sep 2, 2019

hugomrdias Sep 2, 2019

hugomrdias Sep 2, 2019

vasco-santos commented Aug 31, 2019

alanshaw commented Sep 2, 2019

vasco-santos commented Sep 2, 2019

feat: gossipsub as default pubsub #2298

feat: gossipsub as default pubsub #2298

Conversation

vasco-santos commented Jul 24, 2019 • edited by alanshaw Loading

jacobheun commented Jul 31, 2019

jacobheun commented Jul 31, 2019

vasco-santos commented Jul 31, 2019

vasco-santos commented Jul 31, 2019 • edited Loading

jacobheun commented Jul 31, 2019

vasco-santos commented Jul 31, 2019 • edited Loading

alanshaw commented Aug 28, 2019

Choose a reason for hiding this comment

alanshaw commented Aug 28, 2019

vasco-santos commented Aug 28, 2019

alanshaw left a comment

Choose a reason for hiding this comment

vasco-santos Aug 31, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vasco-santos commented Aug 31, 2019

alanshaw commented Sep 2, 2019

vasco-santos commented Sep 2, 2019

vasco-santos commented Jul 24, 2019 •

edited by alanshaw

Loading

vasco-santos commented Jul 31, 2019 •

edited

Loading

vasco-santos commented Jul 31, 2019 •

edited

Loading

vasco-santos Aug 31, 2019 •

edited

Loading