This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
refactor: enable DHT by default #1994
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
3 tasks
alanshaw
force-pushed
the
refactor/enable-dht
branch
from
eb29e66
to
4cbfd99
Compare
|
Let me give you a hand on this |
|
What’s eta on this getting merged |
License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
alanshaw
force-pushed
the
refactor/enable-dht
branch
from
4cbfd99
to
656c375
Compare
License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
|
I've pushed up the config changes here and updated the PR comment to include an updated link to the commit of the changes. |
Closed
6 tasks
vmx
added a commit
that referenced
this pull request
Aug 7, 2019
To find all of those comments run: ```console $ grep DHT test -R |grep TODO test/cli/dht.js:// TODO: unskip when DHT is enabled: #1994 test/core/ping.spec.js: // TODO: unskip when DHT is enabled: #1994 test/core/interface.spec.js: reason: 'TODO: unskip when DHT is enabled: #1994' test/core/dht.spec.js:// TODO: unskip when DHT is enabled: #1994 test/core/name.spec.js: // TODO: unskip when DHT is enabled: #1994 test/http-api/inject/dht.js: // TODO: unskip when DHT is enabled: #1994 test/http-api/interface.js: reason: 'TODO: unskip when DHT is enabled: #1994' ```
alanshaw
pushed a commit
that referenced
this pull request
Aug 7, 2019
To find all of those comments run: ```console $ grep DHT test -R |grep TODO test/cli/dht.js:// TODO: unskip when DHT is enabled: #1994 test/core/ping.spec.js: // TODO: unskip when DHT is enabled: #1994 test/core/interface.spec.js: reason: 'TODO: unskip when DHT is enabled: #1994' test/core/dht.spec.js:// TODO: unskip when DHT is enabled: #1994 test/core/name.spec.js: // TODO: unskip when DHT is enabled: #1994 test/http-api/inject/dht.js: // TODO: unskip when DHT is enabled: #1994 test/http-api/interface.js: reason: 'TODO: unskip when DHT is enabled: #1994' ```
|
Hi! js-ipfs master just got a whole new set of automated tests with #2528, #2440 and also running some of the test suites from our early testers (hi5 to @achingbrain for setting it all up!). Would you mind rebasing the master branch on this PR to ensure it runs all the latest tests? Thank you! |
|
@alanshaw what is the latest state on DHT in JS land? PS: Shouldn't this be labeled as P0? |
|
@daviddias the checklist at the top is up to date. I've labelled it p0. |
13 tasks
|
Fixed by #3947 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: also enables
randomWalkand lowers connection manager limits in the browser.Roadmap to getting DHT enabled by default in JS IPFS (TODO create issues/PRs for all of these):