Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

chore: update comment about skipping the DHT test #2340

Merged
merged 1 commit into from
Aug 7, 2019
Merged

Conversation

vmx
Copy link
Member

@vmx vmx commented Aug 7, 2019

To find all of those comments run:

$ grep DHT test -R |grep TODO
test/cli/dht.js:// TODO: unskip when DHT is enabled: https://github.com/ipfs/js-ipfs/pull/1994
test/core/ping.spec.js:  // TODO: unskip when DHT is enabled: https://github.com/ipfs/js-ipfs/pull/1994
test/core/interface.spec.js:      reason: 'TODO: unskip when DHT is enabled: https://github.com/ipfs/js-ipfs/pull/1994'
test/core/dht.spec.js:// TODO: unskip when DHT is enabled: https://github.com/ipfs/js-ipfs/pull/1994
test/core/name.spec.js:  // TODO: unskip when DHT is enabled: https://github.com/ipfs/js-ipfs/pull/1994
test/http-api/inject/dht.js:  // TODO: unskip when DHT is enabled: https://github.com/ipfs/js-ipfs/pull/1994
test/http-api/interface.js:      reason: 'TODO: unskip when DHT is enabled: https://github.com/ipfs/js-ipfs/pull/1994'

@vmx vmx requested a review from alanshaw August 7, 2019 13:49
To find all of those comments run:

```console
$ grep DHT test -R |grep TODO
test/cli/dht.js:// TODO: unskip when DHT is enabled: #1994
test/core/ping.spec.js:  // TODO: unskip when DHT is enabled: #1994
test/core/interface.spec.js:      reason: 'TODO: unskip when DHT is enabled: #1994'
test/core/dht.spec.js:// TODO: unskip when DHT is enabled: #1994
test/core/name.spec.js:  // TODO: unskip when DHT is enabled: #1994
test/http-api/inject/dht.js:  // TODO: unskip when DHT is enabled: #1994
test/http-api/interface.js:      reason: 'TODO: unskip when DHT is enabled: #1994'
```
@alanshaw alanshaw merged commit 0c6a850 into master Aug 7, 2019
@alanshaw alanshaw deleted the dht-test-comment branch August 7, 2019 14:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants