This repository was archived by the owner on Feb 12, 2024. It is now read-only.
Upgrade to the latest libp2p, ipfs-repo, ipfs-unixfs-*, ipfs-mfs, ipld-* #2390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achingbrain
force-pushed
the
async-await-repo
branch
from
a72e3a8 to
65827db
Compare
achingbrain
force-pushed
the
async-await-repo
branch
2 times, most recently
from
8392583 to
642deaf
Compare
achingbrain
force-pushed
the
async-await-repo
branch
13 times, most recently
from
cc9d222 to
e7ad2dd
Compare
achingbrain
changed the title
achingbrain
requested review from
hugomrdias
and removed request for
hugomrdias
achingbrain
force-pushed
the
async-await-repo
branch
9 times, most recently
from
9dca472 to
d1ab722
Compare
achingbrain
force-pushed
the
async-await-repo
branch
3 times, most recently
from
2e2a5c6 to
9ad9249
Compare
This was referenced Sep 26, 2019
Closed
hugomrdias
suggested changes
Sep 26, 2019
|
can you change the max bundle size to 683 ? |
This new version of ipfsd-ctl is using async/await instead of callbacks. Hence some rather mechanical changes are needed for tests.
This is WIP and IPFS doesn't even start properly.
achingbrain
force-pushed
the
async-await-repo
branch
from
9ad9249 to
99d7410
Compare
hugomrdias
approved these changes
Sep 26, 2019
hugomrdias
approved these changes
Sep 26, 2019
This was referenced Oct 2, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my current work on integrating the async/await based ipfs-repo into ipfs.
I just push what I have now, with all those commented out things and debugging statements.
If someone feels like pushing it further, feel free, I won't work on this until at least 2019-09-03.