-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Conversation
I think most of the core tests should be moved to either That'd leave us with just cli, gateway and http tests in this repo, and the http tests should all be converted to What do you think @hugomrdias @alanshaw @jacobheun @vasco-santos |
yes im working on that and moving interface-core to async also |
Well I'll just sit right back then... ...and convert the gateway & http tests to async/await. Will leave the core ones alone. |
@hugomrdias please de-dupe with extreme prejudice! |
Ideally the cli tests should only need to verify that the interface is called correctly and that interface outputs are printed properly. We shouldn't need to run ipfs at all for the cli tests and it would make them take seconds instead of minutes. |
9ad9249
to
99d7410
Compare
yes i already changed a couple of sub systems to work like that, and doing the rest is on my todo list |
Our http tests in `js-IPFS` duplicate a whole bunch of tests from this suite, but they also test some unhappy paths that this suite does not. I've pulled them out of `js-IPFS` as part of ipfs/js-ipfs#2495 and am adding them to the interface tests here.
3fc853f
to
8f505a5
Compare
I've pulled out all the http tests that start a daemon in the background. Most were duplicates of tests in the I've added them to the interface tests here: ipfs-inactive/interface-js-ipfs-core#534 |
Our http tests in `js-IPFS` duplicate a whole bunch of tests from this suite, but they also test some unhappy paths that this suite does not. I've pulled them out of `js-IPFS` as part of ipfs/js-ipfs#2495 and am adding them to the interface tests here.
Our http tests in `js-IPFS` duplicate a whole bunch of tests from this suite, but they also test some unhappy paths that this suite does not. I've pulled them out of `js-IPFS` as part of ipfs/js-ipfs#2495 and am adding them to the interface tests here.
Our http tests in `js-IPFS` duplicate a whole bunch of tests from this suite, but they also test some unhappy paths that this suite does not. I've pulled them out of `js-IPFS` as part of ipfs/js-ipfs#2495 and am adding them to the interface tests here.
Builds on the work in #2390
core@hugomrdias is doing thesegatewayThese were already async awaitinterface-js-ipfs-core
- if not duplicates they were moved to the interface tests