This repository was archived by the owner on Feb 12, 2024. It is now read-only.
feat: dag get cli #688
Closed
feat: dag get cli #688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victorb
reviewed
Dec 27, 2016
|
|
||
| describe('dag', () => { | ||
| describeOnlineAndOffline(repoPath, () => { | ||
| it('get', () => { |
There was a problem hiding this comment.
Should probably have a test-case as well when we try to resolve a hash that does not exists.
There was a problem hiding this comment.
Yeah I wanted to write more extensive tests but I couldn't even get them to run bc of some issue with a networking module
daviddias
added
status/ready
|
@kumavis I was rebasing master on this branch to then realise this PR was made to a old branch and not against master. Mind rebasing and PR'ing against master? |
|
replaced by #753 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is the skeleton for the
dagcli command, and an implementation ofdag get <ref>whererefis {<cid>or<cid>/<path>}.Not sure what the formatting for output should be, just logging the result as-in for now.
Was unable to run the test due to some unrelated bug on test start, but should be correct.