Skip to content
This repository was archived by the owner on Feb 12, 2024. It is now read-only.

cli - add 'dag get' command #753

Merged
merged 2 commits into from
Feb 3, 2017
Merged

cli - add 'dag get' command #753

merged 2 commits into from
Feb 3, 2017

Conversation

kumavis
Copy link
Contributor

@kumavis kumavis commented Feb 2, 2017

No description provided.

@jbenet jbenet added the status/in-progress In progress label Feb 2, 2017
@kumavis kumavis mentioned this pull request Feb 2, 2017
Copy link
Member

@daviddias daviddias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, going to merge. Missing still the dag put

lookupFn = () => ipfs.dag.resolve(cid, pathString)
} else {
lookupFn = () => ipfs.dag.get(cid)
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@whyrusleeping convinced me that we should merge this two funcs yesterday, will be writing something explaining what will happen in the next hour, but yeah, for now 👌🏽

@daviddias daviddias merged commit 26567f5 into master Feb 3, 2017
@daviddias daviddias deleted the feat/dag-cli2 branch February 3, 2017 14:49
@daviddias daviddias removed the status/in-progress In progress label Feb 3, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants