Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker image for ARM #4931

Closed
yrzr opened this issue Apr 11, 2018 · 8 comments · Fixed by #8633
Closed

docker image for ARM #4931

yrzr opened this issue Apr 11, 2018 · 8 comments · Fixed by #8633
Labels
help wanted Seeking public contribution on this issue kind/feature A new feature status/in-progress In progress topic/ARM Issues related to running on ARM topic/build Topic build topic/containers + vms topic/releases Topic releases

Comments

@yrzr
Copy link

yrzr commented Apr 11, 2018

Since we do have ARM build, why not an ARM docker image?

The official images arm32v7/golang and arm32v7/busybox can be used as the base image.

Moreover, COPY --from=0 /lib/x86_64-linux-gnu/libdl-2.24.so /lib/libdl.so.2 should be changed to COPY --from=0 /lib/arm-linux-gnueabihf/libdl-2.24.so /lib/libdl.so.2 and && wget -q -O tini https://github.com/krallin/tini/releases/download/$TINI_VERSION/tini \ should be changed to && wget -q -O tini https://github.com/krallin/tini/releases/download/$TINI_VERSION/tini-armhf \

I've successfully built images here.

@lgierth

@johnelliott
Copy link

I just ran the @yrzr image successfully. 👍

@johnelliott
Copy link

@yrzr I see you've made some CI code to maintain that image, but it looks like it's based of modifying the dockerfile here with the changes you outlined above. Are these changes something we could commit to this repository?

@yrzr
Copy link
Author

yrzr commented Aug 6, 2018

@johnelliott Thank you for your reply. It seems that writing a dedicated Dockerfile.arm file, build and push corresponding images to docker hub is a common solution.

@yrzr
Copy link
Author

yrzr commented Aug 6, 2018

@johnelliott My modifications are meant to be built on ARM. If one wants to build ARM images on x86, here is a solution.

@johnelliott
Copy link

johnelliott commented Aug 6, 2018

Yes, I did not yet try to build the same image with your changes on the hypriot-pi machine but I have no doubt it will work similarly.

If the convention exists to have an additional Dockerfile in this repo then I support that idea. It seems more difficult to maintain it in a separate repository

@Stebalien Stebalien added help wanted Seeking public contribution on this issue topic/releases Topic releases topic/build Topic build kind/feature A new feature labels Aug 6, 2018
@johnelliott
Copy link

johnelliott commented Aug 9, 2018

I successfully built and ran a node with @yrzr's proposed changes based on https://github.com/yrzr/go-ipfs-armhf/blob/master/.gitlab-ci.yml. If it was this simple I think others would benefit.

@Stebalien If I make pr, would there be more to set up (CI?) in addition to the dockerfile?

@roderik
Copy link

roderik commented Mar 8, 2021

since the amd64 image was crashing on quemu on a M1 mac, i quickly built 0.8.0 on github for arm as well using github actions. No changes needed, just the GHA actions.

https://github.com/settlemint/go-ipfs/blob/feat/arm-build/.github/workflows/docker.yml

Image is available here: https://hub.docker.com/repository/docker/settlemint/go-ipfs

@odanado
Copy link
Contributor

odanado commented Dec 28, 2021

I've created various versions of go-ipfs Docker Images.

Docker Hub: https://hub.docker.com/r/odanado/go-ipfs/tags
GitHub: https://github.com/odanado/go-ipfs-docker

odanado added a commit to odanado/go-ipfs that referenced this issue Dec 28, 2021
odanado added a commit to odanado/go-ipfs that referenced this issue Jan 2, 2022
guseggert pushed a commit that referenced this issue Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Seeking public contribution on this issue kind/feature A new feature status/in-progress In progress topic/ARM Issues related to running on ARM topic/build Topic build topic/containers + vms topic/releases Topic releases
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants