-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docker image for ARM #4931
Comments
I just ran the @yrzr image successfully. 👍 |
@yrzr I see you've made some CI code to maintain that image, but it looks like it's based of modifying the dockerfile here with the changes you outlined above. Are these changes something we could commit to this repository? |
@johnelliott Thank you for your reply. It seems that writing a dedicated |
@johnelliott My modifications are meant to be built on ARM. If one wants to build ARM images on x86, here is a solution. |
Yes, I did not yet try to build the same image with your changes on the hypriot-pi machine but I have no doubt it will work similarly. If the convention exists to have an additional Dockerfile in this repo then I support that idea. It seems more difficult to maintain it in a separate repository |
I successfully built and ran a node with @yrzr's proposed changes based on https://github.com/yrzr/go-ipfs-armhf/blob/master/.gitlab-ci.yml. If it was this simple I think others would benefit. @Stebalien If I make pr, would there be more to set up (CI?) in addition to the dockerfile? |
since the amd64 image was crashing on quemu on a M1 mac, i quickly built 0.8.0 on github for arm as well using github actions. No changes needed, just the GHA actions. https://github.com/settlemint/go-ipfs/blob/feat/arm-build/.github/workflows/docker.yml Image is available here: https://hub.docker.com/repository/docker/settlemint/go-ipfs |
I've created various versions of go-ipfs Docker Images. Docker Hub: https://hub.docker.com/r/odanado/go-ipfs/tags |
Since we do have ARM build, why not an ARM docker image?
The official images arm32v7/golang and arm32v7/busybox can be used as the base image.
Moreover,
COPY --from=0 /lib/x86_64-linux-gnu/libdl-2.24.so /lib/libdl.so.2
should be changed toCOPY --from=0 /lib/arm-linux-gnueabihf/libdl-2.24.so /lib/libdl.so.2
and&& wget -q -O tini https://github.com/krallin/tini/releases/download/$TINI_VERSION/tini \
should be changed to&& wget -q -O tini https://github.com/krallin/tini/releases/download/$TINI_VERSION/tini-armhf \
I've successfully built images here.
@lgierth
The text was updated successfully, but these errors were encountered: