Add arm32 Dockerfile #5370

johnelliott · 2018-08-10T23:15:51Z

...or just related, looking for assistance form maintainers for what additional work to do here to maintain the image

ghost · 2018-08-10T23:20:09Z

Looks good -- but are libld path and tini filename the only differences? If so, is there a way we could just parameterize the existing dockerfile?

johnelliott · 2018-08-11T00:29:13Z

According to @yrzr here and my experience building, that was the only thing required. They mentioned that it is a convention, however given the small difference I was wondering the same thing.

johnelliott · 2018-08-13T14:28:29Z

I've looked at some ways to parameterize the Dockerfile but haven't begun work on it.

johnelliott · 2018-08-18T17:38:43Z

Side note here: The GitCop template links respond with 404.

johnelliott · 2018-08-19T23:23:38Z

@lgierth I updated the existing Dockerfiles with parameters and successfully built them on Mac and Raspberry Pi. I need assistance knowing what to do next. I was looking for how to test, if there are automated tests for this.

I'm also curious if we can hook this up to CI so others can just pull down an arm image.

ghost · 2018-08-23T21:11:13Z

Nice, this looks good to me!

The next steps are documenting the build args in the Dockerfiles themselves and in the README.md docker section.

And maybe (later) we can have Makefile targets a la make docker_amd64 and make docker_armv7.

Sorry, too early -- need docs, see my comment

johnelliott · 2018-08-23T22:06:36Z

OK, I will first see if a convention exists for such documentation and add some notes. I see the existing comment about maintaining the faster-building file. I'll update the readme also.

License: MIT Signed-off-by: Kunal Mahajan <mkunal@cs.columbia.edu>

License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>

Allow, for example: $ docker -v build . -f Dockerfile.fast --build-arg base=arm32v7/golang:1.10-stretch --build-arg tini_executable=tini-armhf --build-arg 'busybox_base=arm32v7/busybox:1-glibc' --build-arg glibc_shared_lib_arch=arm-linux-gnueabihf to build for a Raspberry Pi (arm32v7) License: MIT Signed-off-by: John Elliott <johnelliott703@gmail.com>

johnelliott · 2018-09-08T02:03:24Z

I added documentation of the arguments and some notes to the README with example build commands

johnelliott · 2018-10-05T19:36:03Z

Looks like I'll need to give this some more attention until a maintainer can review and merge this.

doodlemania2 · 2018-12-01T03:19:12Z

any update on this? looking for an ipfs docker container for armhf

yrzr · 2018-12-01T05:52:04Z

@doodlemania2 Seems they haven't added the docker images yet. You can use my builds for arm32v7(armhf) and arm64v8(aarch) first. Or you can build your own images following #4931.

johnelliott · 2018-12-01T14:57:32Z

@doodlemania2 I got started with @yrzr's work and this PR is based on his work. Your fastest path forward is using their builds. I used them successfully before starting this branch

I just updated my fork via the website and I may need to pull it down to a license commit.

doodlemania2 · 2018-12-02T21:42:00Z

Thanks all!

Stebalien

This looks good modulo some out of date documentation.

However, as I'm not familiar with docker, I'd also like to sanity check a few things (see the review comments)

Stebalien · 2018-12-03T19:37:13Z

Dockerfile

+# Go base image
+ARG base=golang:1.11-stretch
+# Busybox base image
+ARG busybox_base=busybox:1-glibc


I'm not a docker expert, but shouldn't this just go down at line 46? Is there a reason to duplicate it?

Stebalien · 2018-12-03T19:41:03Z

README.md

@@ -317,6 +317,48 @@ Stop the running container:

    docker stop ipfs_host

+### Building Docker images


Should be updated for go 1.11.

Stebalien · 2018-12-03T19:45:29Z

README.md

+#### `busybox_base`
+Possible values:
+- `busybox:1-glibc` (default)
+- `arm32v7/golang:1.10-stretch`


Stebalien · 2018-12-03T19:51:50Z

README.md

+- `base`: The base go image for the target platform
+- `busybox_base`: The busybox base image for the target platform
+- `tini_executable`: The tini executable path for the target platform
+- `glibc_shared_lib_arch`: The target platform shared lib for glibc supplementing busybox


Is there really no better way to do this (i.e., with one variable). From what I can tell, there simply isn't but I'm not a Docker expert so I'd like to double check.

Same here. This was seemingly the only way.

johnelliott · 2018-12-10T15:59:41Z

I may get to this this week :)

johnelliott · 2019-01-03T15:46:46Z

There doesn't seem to be sufficient desire for this change yet so I'm closing this PR. Anyone else can feel free to take it up again :)

Stebalien · 2019-01-03T22:12:39Z

Yeah, sorry about that. This looks useful but nobody (that I know of) on the current team has extensive knowledge of docker or the need to run go-ipfs on arm. That makes this a bit difficult to validate, test, and maintain.

However, if someone has a real need for this, please comment and we can reopen (or continue in a new PR).

doodlemania2 · 2019-01-04T19:03:49Z

Thanks all - I ended up rolling my own: https://github.com/doodlemania2/ethereum-armhf based on other's work.

master-hax · 2021-12-19T11:26:52Z

btw the go-ipfs docker images provided by linuxserver.io work on armhf: https://hub.docker.com/r/linuxserver/ipfs

johnelliott requested a review from Kubuxu as a code owner August 10, 2018 23:15

Stebalien added the need/author-input Needs input from the original author label Aug 16, 2018

Stebalien requested a review from a user August 20, 2018 21:08

Stebalien added need/review Needs a review and removed need/author-input Needs input from the original author labels Aug 20, 2018

ghost previously approved these changes Aug 23, 2018

View reviewed changes

Stebalien added need/author-input Needs input from the original author need_docs and removed need/review Needs a review labels Aug 23, 2018

kvm2116 and others added 4 commits September 7, 2018 22:00

Fixed ipns address resolution in fuse unix mount

18c561e

License: MIT Signed-off-by: Kunal Mahajan <mkunal@cs.columbia.edu>

fix go style

6299189

License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>

add test case for /ipns/QmId...

cb439ab

License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>

Stebalien removed need_docs need/author-input Needs input from the original author labels Sep 11, 2018

Stebalien requested a review from a user September 11, 2018 01:03

Stebalien added the need/review Needs a review label Sep 11, 2018

Merge branch 'master' into master

5729581

Stebalien requested changes Dec 3, 2018

View reviewed changes

Stebalien added need/author-input Needs input from the original author and removed need/review Needs a review labels Dec 3, 2018

johnelliott closed this Jan 3, 2019

Stebalien removed the need/author-input Needs input from the original author label Jan 3, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add arm32 Dockerfile #5370

Add arm32 Dockerfile #5370

johnelliott commented Aug 10, 2018 •

edited

Loading

ghost commented Aug 10, 2018

johnelliott commented Aug 11, 2018

johnelliott commented Aug 13, 2018

johnelliott commented Aug 18, 2018 •

edited

Loading

johnelliott commented Aug 19, 2018

ghost commented Aug 23, 2018

johnelliott commented Aug 23, 2018

johnelliott commented Sep 8, 2018 •

edited

Loading

johnelliott commented Oct 5, 2018

doodlemania2 commented Dec 1, 2018

yrzr commented Dec 1, 2018 •

edited

Loading

johnelliott commented Dec 1, 2018 •

edited

Loading

doodlemania2 commented Dec 2, 2018

Stebalien left a comment

Stebalien Dec 3, 2018

Stebalien Dec 3, 2018

Stebalien Dec 3, 2018

Stebalien Dec 3, 2018

johnelliott Dec 3, 2018

johnelliott commented Dec 10, 2018

johnelliott commented Jan 3, 2019

Stebalien commented Jan 3, 2019

doodlemania2 commented Jan 4, 2019

master-hax commented Dec 19, 2021

		@@ -317,6 +317,48 @@ Stop the running container:

		docker stop ipfs_host

		### Building Docker images

Add arm32 Dockerfile #5370

Add arm32 Dockerfile #5370

Conversation

johnelliott commented Aug 10, 2018 • edited Loading

ghost commented Aug 10, 2018

johnelliott commented Aug 11, 2018

johnelliott commented Aug 13, 2018

johnelliott commented Aug 18, 2018 • edited Loading

johnelliott commented Aug 19, 2018

ghost commented Aug 23, 2018

johnelliott commented Aug 23, 2018

johnelliott commented Sep 8, 2018 • edited Loading

johnelliott commented Oct 5, 2018

doodlemania2 commented Dec 1, 2018

yrzr commented Dec 1, 2018 • edited Loading

johnelliott commented Dec 1, 2018 • edited Loading

doodlemania2 commented Dec 2, 2018

Stebalien left a comment

Choose a reason for hiding this comment

Stebalien Dec 3, 2018

Choose a reason for hiding this comment

Stebalien Dec 3, 2018

Choose a reason for hiding this comment

Stebalien Dec 3, 2018

Choose a reason for hiding this comment

Stebalien Dec 3, 2018

Choose a reason for hiding this comment

johnelliott Dec 3, 2018

Choose a reason for hiding this comment

johnelliott commented Dec 10, 2018

johnelliott commented Jan 3, 2019

Stebalien commented Jan 3, 2019

doodlemania2 commented Jan 4, 2019

master-hax commented Dec 19, 2021

johnelliott commented Aug 10, 2018 •

edited

Loading

johnelliott commented Aug 18, 2018 •

edited

Loading

johnelliott commented Sep 8, 2018 •

edited

Loading

yrzr commented Dec 1, 2018 •

edited

Loading

johnelliott commented Dec 1, 2018 •

edited

Loading